Bug 76634 – [chromium] Replace WGC3D visibility extension with resource_usage extension. [Part 1 of 3]

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Michal Mocny]

[chromium] Replace WGC3D visibility extension with resource_usage extension. [Part 1 of 3]

[Michal Mocny]

Created attachment 123125 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Michal Mocny]

Part2 (chromium side patch) is here: http://codereview.chromium.org/9192014/

Ken, I was hoping you could take a look here, especially at the location I added the ResourceUsage enum.

[Kenneth Russell]

Comment on attachment 123125 [details]
Patch

Looks fine. In general, Chromium extensions added to WebGraphicsContext3D should be mirrored in src/third_party/khronos/GLES2/gl2ext.h, and follow those API conventions (meaning that OpenGL enum values would need to be assigned, rather than using a local enum). However, since this is an API that is only executed on the client side and isn't mirrored in the GL API, the structure here is fine. r=me

[WebKit Review Bot]

Comment on attachment 123125 [details]
Patch

Rejecting attachment 123125 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11300150

[Michal Mocny]

Created attachment 123151 [details]
Patch

[Kenneth Russell]

Comment on attachment 123151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123151&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        Reviewed by Kenneth Russell.

Just leave the "Reviewed by NOBODY (OOPS!)" line alone in the future. The commit queue will fill it in automatically.

[Kenneth Russell]

Comment on attachment 123151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123151&action=review

> Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h:154
> +    // TODO(mmocny): remove visibility once chromium patch lands

I neglected to point out that WebKit uses FIXME comments rather than TODOs.

[WebKit Review Bot]

Comment on attachment 123151 [details]
Patch

Clearing flags on attachment: 123151

Committed r105462: <http://trac.webkit.org/changeset/105462>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.