Bug 76625 - Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline
Summary: Cleanup: make constant variable names in fileapi/ conform to WebKit's coding ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kinuko Yasuda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 05:14 PST by Kinuko Yasuda
Modified: 2012-01-19 22:39 PST (History)
4 users (show)

See Also:

Attachments
Patch (10.85 KB, patch)
2012-01-19 05:31 PST, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2012-01-19 05:14:54 PST 
Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline.

Many of the constant variables defined there are following chrome's coding style (like kFoo).
(Leftover from issue 76551)
Comment 1 Kinuko Yasuda 2012-01-19 05:31:02 PST 
Created attachment 123114 [details]
Patch
Comment 2 Kinuko Yasuda 2012-01-19 05:55:03 PST 
Mechanical changes only.
Comment 3 David Levin 2012-01-19 09:53:26 PST 
Comment on attachment 123114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123114&action=review

> Source/WebCore/platform/AsyncFileSystem.cpp:94
> +bool AsyncFileSystem::isAvailable()

Why did this get added?
Comment 4 Eric U. 2012-01-19 11:27:07 PST 
Comment on attachment 123114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123114&action=review

>> Source/WebCore/platform/AsyncFileSystem.cpp:94
>> +bool AsyncFileSystem::isAvailable()
> 
> Why did this get added?

Looks like it came from line 67 above.
Comment 5 David Levin 2012-01-19 11:33:13 PST 
Comment on attachment 123114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123114&action=review

>>> Source/WebCore/platform/AsyncFileSystem.cpp:94
>>> +bool AsyncFileSystem::isAvailable()
>> 
>> Why did this get added?
> 
> Looks like it came from line 67 above.

Thanks.
Comment 6 WebKit Review Bot 2012-01-19 22:39:36 PST 
Comment on attachment 123114 [details]
Patch

Clearing flags on attachment: 123114

Committed r105483: <http://trac.webkit.org/changeset/105483>
Comment 7 WebKit Review Bot 2012-01-19 22:39:41 PST 
All reviewed patches have been landed.  Closing bug.