Bug 76620 - [GTK] GTK's DRT not to log events for already defunct objects
Summary: [GTK] GTK's DRT not to log events for already defunct objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 76531
  Show dependency tree / graph
 
Reported: 2012-01-19 04:05 PST by Mario Sanchez Prada
Modified: 2012-01-20 01:57 PST (History)
1 user (show)

See Also:

Attachments
Patch proposal (5.24 KB, patch)
2012-01-19 04:36 PST, Mario Sanchez Prada 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2012-01-19 04:05:55 PST 
If an AtkObject has emmitted the 'state-change::defunct' function it means it is not a valid object anymore, so we should not do anything about it, like trying to retrieve its name and role for loggint purposes, which is what printAccessibilityEvent() in Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp does.

Filing this bug now since recent changes in the repository (r105253) unveiled that not controlling this situation could lead to DRT segfaulting in some tests (like platform/gtk/accessibility/combo-box-collapsed-selection-changed.html, which is skipped at the time of this writing).
Comment 1 Mario Sanchez Prada 2012-01-19 04:10:21 PST 
We can't fix bug 76531 until we fix this other one, as DRT will segfault otherwise.
Comment 2 Mario Sanchez Prada 2012-01-19 04:36:37 PST 
Created attachment 123104 [details]
Patch proposal
Comment 3 Martin Robinson 2012-01-19 09:20:47 PST 
Comment on attachment 123104 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=123104&action=review

> Tools/ChangeLog:8
> +        Do not to log 'state-change:defunct' events.

Do not to log -> Do not log
Comment 4 Mario Sanchez Prada 2012-01-20 01:57:43 PST 
Committed r105496: <http://trac.webkit.org/changeset/105496>