Bug 76616 - [GTK] Add print-backgrounds setting to WebKit2 GTK+ API
Summary: [GTK] Add print-backgrounds setting to WebKit2 GTK+ API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 75544
  Show dependency tree / graph
 
Reported: 2012-01-19 03:14 PST by Carlos Garcia Campos
Modified: 2012-01-19 09:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2012-01-19 03:16 PST, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-01-19 03:14:34 PST 
To allow disabling print brackgrounds.
Comment 1 Carlos Garcia Campos 2012-01-19 03:16:51 PST 
Created attachment 123093 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-19 03:20:05 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2012-01-19 09:05:31 PST 
Comment on attachment 123093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123093&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:761
> +     * Whether background images should be printed.

Oh, you should probably be more explicit here that this happens only during printing runs.
Comment 4 Carlos Garcia Campos 2012-01-19 09:31:15 PST 
Committed r105417: <http://trac.webkit.org/changeset/105417>