Bug 76608 - [Chromium] [WebSocket] Remove binary communication using WebData in WebKit API
Summary: [Chromium] [WebSocket] Remove binary communication using WebData in WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Toyoshima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 23:41 PST by Takashi Toyoshima
Modified: 2012-01-23 18:19 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.79 KB, patch)
2012-01-18 23:50 PST, Takashi Toyoshima 		no flags Details | Formatted Diff | Diff
Patch for landing (6.79 KB, patch)
2012-01-23 05:04 PST, Takashi Toyoshima 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2012-01-18 23:41:32 PST 
WebData is used experimentally for binary communication between WebKit and Chromium.
Now, WebArrayBuffer is the better way to implement it, and Chromium use it now.

I'd like to remove this obsoleted WebData support from WebKit API because it's not used now.
Comment 1 Takashi Toyoshima 2012-01-18 23:50:10 PST 
Created attachment 123083 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-18 23:54:49 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 WebKit Review Bot 2012-01-19 00:16:56 PST 
Comment on attachment 123083 [details]
Patch

Attachment 123083 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11247035
Comment 4 Takashi Toyoshima 2012-01-19 00:30:21 PST 
Ah, Cr > r118258 is required to pass.
I'll try it again later.
Comment 5 Takashi Toyoshima 2012-01-23 05:04:43 PST 
Created attachment 123542 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-01-23 18:19:14 PST 
Comment on attachment 123542 [details]
Patch for landing

Clearing flags on attachment: 123542

Committed r105675: <http://trac.webkit.org/changeset/105675>
Comment 7 WebKit Review Bot 2012-01-23 18:19:19 PST 
All reviewed patches have been landed.  Closing bug.