Bug 76573 – Make WebAudio API const-correct.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Jer Noble]

Make WebAudio API const-correct.

[Jer Noble]

Created attachment 122999 [details]
Patch

[Chris Rogers]

Looks fine to me, assuming the bots pass.

[WebKit Review Bot]

Comment on attachment 122999 [details]
Patch

Attachment 122999 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11282375

[Jer Noble]

Whoops, forgot to modify the platform-specific implementations.

[Jer Noble]

Created attachment 123022 [details]
Patch

Made platform-specific implementations match their platform-neutral declarations. Found more functions which needed const-correcting.

[WebKit Review Bot]

Comment on attachment 123022 [details]
Patch

Attachment 123022 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11284397

[Jer Noble]

Created attachment 123035 [details]
Patch

Yet more platform-specific fixes.

[WebKit Review Bot]

Comment on attachment 123035 [details]
Patch

Attachment 123035 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11284444

[Jer Noble]

Created attachment 123063 [details]
Patch

Ditto.

[WebKit Review Bot]

Comment on attachment 123063 [details]
Patch

Attachment 123063 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11211912

[Jer Noble]

Created attachment 123070 [details]
Patch

Double ditto.

[WebKit Review Bot]

Comment on attachment 123070 [details]
Patch

Attachment 123070 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11300014

[Jer Noble]

Created attachment 123147 [details]
Patch

Another day, another platform-specific compile error.

[Daniel Bates]

Comment on attachment 123147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123147&action=review

> Source/WebCore/platform/audio/SincResampler.cpp:139
> +    // FIXME: find a way to make the following const-correct:

Nit: "find" => "Find".

You may want to consider filling a WebKit bug for this so as to make it actionable.

[Jer Noble]

(In reply to comment #14)
> (From update of attachment 123147 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123147&action=review
> 
> > Source/WebCore/platform/audio/SincResampler.cpp:139
> > +    // FIXME: find a way to make the following const-correct:
> 
> Nit: "find" => "Find".
> 
> You may want to consider filling a WebKit bug for this so as to make it actionable.

Will do.  Thanks!

[WebKit Review Bot]

Comment on attachment 123147 [details]
Patch

Attachment 123147 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11253559

New failing tests:
fullscreen/full-screen-iframe-zIndex.html

[Jer Noble]

(In reply to comment #16)
> (From update of attachment 123147 [details])
> Attachment 123147 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11253559
> 
> New failing tests:
> fullscreen/full-screen-iframe-zIndex.html

Whoops, that test snuck into my patch.  I'll excise it before committing.

[Jer Noble]

Committed r105431: <http://trac.webkit.org/changeset/105431>

[Jer Noble]

In the end, SincResampler::consumeSource did not need to take a const parameter (as it was a convenience function which operates on a mutable buffer), so its change (and thus the FIXME) were unnecessary.