Bug 76568 - HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading
Summary: HTMLMediaElement should fire 'progress' event before 'idle' if it was previou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Victoria Kirst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 13:59 PST by Victoria Kirst
Modified: 2012-01-18 17:19 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.02 KB, patch)
2012-01-18 14:02 PST, Victoria Kirst
no flags Details | Formatted Diff | Diff
Patch (4.15 KB, patch)
2012-01-18 15:50 PST, Victoria Kirst
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victoria Kirst 2012-01-18 13:59:04 PST
HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading
Comment 1 Victoria Kirst 2012-01-18 14:02:11 PST
Created attachment 122987 [details]
Patch
Comment 2 Eric Carlson 2012-01-18 14:43:44 PST
Comment on attachment 122987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122987&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests. (OOPS!)

"(OOPS!)" will cause the patch to be rejected by the commit-hook. Please add an explanation of why there are no new tests.

> Source/WebCore/html/HTMLMediaElement.cpp:1300
> +void HTMLMediaElement::setNetworkStateFromLoadingToIdle()

Nit: I think a better name would be "changeNetworkStateFromLoadingToIdle"
Comment 3 Victoria Kirst 2012-01-18 15:50:15 PST
Created attachment 123025 [details]
Patch
Comment 4 Victoria Kirst 2012-01-18 15:50:42 PST
Thanks for the speedy review, Eric! Updated patch with your suggestions.
Comment 5 Victoria Kirst 2012-01-18 17:19:55 PST
Committed r105365: <http://trac.webkit.org/changeset/105365>