RESOLVED FIXED 76548
Web Inspector: there should be a way to set HTML for given frame. 
https://bugs.webkit.org/show_bug.cgi?id=76548
Summary Web Inspector: there should be a way to set HTML for given frame.
Pavel Feldman
Reported 2012-01-18 09:18:49 PST
Patch to follow.
Attachments
Patch (5.92 KB, patch)
2012-01-18 09:32 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-01-18 09:32:53 PST
Created attachment 122946 [details] Patch
Yury Semikhatsky
Comment 2 2012-01-18 09:36:54 PST
Comment on attachment 122946 [details] Patch Can we have a test for this?
Timothy Hatcher
Comment 3 2012-01-18 09:49:44 PST
Comment on attachment 122946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122946&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:-1144 > - var doc = this._domAgent._documentURLToDocument[resource.url]; Do you still need the _documentURLToDocument map? I feel that map is flawed in the case where multiple frames with the same URL exist. And this patch fixes that issue by using frameId. Who still needs _documentURLToDocument?
Pavel Feldman
Comment 4 2012-01-18 09:54:03 PST
(In reply to comment #3) > (From update of attachment 122946 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122946&action=review > > > Source/WebCore/inspector/front-end/DOMAgent.js:-1144 > > - var doc = this._domAgent._documentURLToDocument[resource.url]; > > Do you still need the _documentURLToDocument map? I feel that map is flawed in the case where multiple frames with the same URL exist. And this patch fixes that issue by using frameId. Who still needs _documentURLToDocument? Good point. Will nuke it prior to landing.
Timothy Hatcher
Comment 5 2012-01-18 09:55:44 PST
Great!
Pavel Feldman
Comment 6 2012-01-18 09:57:01 PST
Committed r105288: <http://trac.webkit.org/changeset/105288>
Pavel Feldman
Comment 8 2012-01-18 10:59:16 PST
(In reply to comment #7) > Seems like it makes Qt regress again: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r105288%20(32590)/inspector/elements/set-html-via-resource-pretty-diff.html Fixed it, sorry about that.
Note You need to log in before you can comment on or make changes to this bug.