RESOLVED FIXED76533
Web Inspector: resource tree model leaks frames 
https://bugs.webkit.org/show_bug.cgi?id=76533
Summary Web Inspector: resource tree model leaks frames
Andrey Kosyakov
Reported 2012-01-18 05:31:30 PST
We never remove frames from ResourceTreeModel._frames. To test for that: - open inspector - navigate to a few sites - open inspector on inspector - check WebInspector.resourceTreeModel._frames -- it contains frames belonging to all sites visited.
Attachments
Patch (2.27 KB, patch)
2012-01-18 05:57 PST, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2012-01-18 06:30 PST, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-01-18 05:57:14 PST
Created attachment 122910 [details] Patch
Pavel Feldman
Comment 2 2012-01-18 06:10:57 PST
Comment on attachment 122910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122910&action=review > Source/WebCore/inspector/front-end/ResourceTreeModel.js:199 > + _removeFrame: function(frame) This method should be defined in frame.
Andrey Kosyakov
Comment 3 2012-01-18 06:30:09 PST
Created attachment 122917 [details] Patch
Pavel Feldman
Comment 4 2012-01-18 07:08:56 PST
Comment on attachment 122917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122917&action=review > Source/WebCore/inspector/front-end/ResourceTreeModel.js:524 > + frame._remove(); I think this should be the last line in the method (after the childFrames.remove) > Source/WebCore/inspector/front-end/ResourceTreeModel.js:538 > + this._model.dispatchEventToListeners(WebInspector.ResourceTreeModel.EventTypes.FrameDetached, this); Also, dispatch as the last line.
Andrey Kosyakov
Comment 5 2012-01-18 07:22:28 PST
Committed r105274: <http://trac.webkit.org/changeset/105274>
Note You need to log in before you can comment on or make changes to this bug.