Bug 76530 - Cross-platform processor core counter
Summary: Cross-platform processor core counter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 04:17 PST by Roland Takacs
Modified: 2012-01-18 14:05 PST (History)
9 users (show)

See Also:


Attachments
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp (17.18 KB, patch)
2012-01-18 04:48 PST, Roland Takacs
no flags Details | Formatted Diff | Diff
I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)" (17.34 KB, patch)
2012-01-18 06:20 PST, Roland Takacs
rtakacs: review-
rtakacs: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Takacs 2012-01-18 04:17:25 PST
Two files have been added to the project, namely NumberOfCores.h/cpp,
that include a CPU core number determining function. It used to be
in ParallelJobsGeneric.h/cpp before.
Comment 1 Roland Takacs 2012-01-18 04:48:13 PST
Created attachment 122902 [details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp

"determineMaxNumberOfParallelThreads()" has been renamed to "NumberOfProcessorCores()".
Comment 2 Zoltan Herczeg 2012-01-18 04:54:01 PST
Comment on attachment 122902 [details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp

r=me
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-01-18 05:37:46 PST
Comment on attachment 122902 [details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp

View in context: https://bugs.webkit.org/attachment.cgi?id=122902&action=review

> Source/JavaScriptCore/wtf/NumberOfCores.cpp:29
> +#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)

Note you also need to add || OS(FREEBSD) here as you use it below, or the build will break on it.
Comment 4 Roland Takacs 2012-01-18 06:13:22 PST
Thanks for warning me, I have fixed it.

(In reply to comment #3)
> (From update of attachment 122902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122902&action=review
> 
> > Source/JavaScriptCore/wtf/NumberOfCores.cpp:29
> > +#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)
> 
> Note you also need to add || OS(FREEBSD) here as you use it below, or the build will break on it.
Comment 5 WebKit Review Bot 2012-01-18 06:15:24 PST
Comment on attachment 122902 [details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp

Clearing flags on attachment: 122902

Committed r105270: <http://trac.webkit.org/changeset/105270>
Comment 6 WebKit Review Bot 2012-01-18 06:15:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Roland Takacs 2012-01-18 06:20:40 PST
Created attachment 122914 [details]
I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)"
Comment 8 Csaba Osztrogonác 2012-01-18 07:22:26 PST
Qt Windows (cross-MinGW) buildfix landed in http://trac.webkit.org/changeset/105273