WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76530
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Summary
Cross-platform processor core counter
Roland Takacs
Reported
2012-01-18 04:17:25 PST
Two files have been added to the project, namely NumberOfCores.h/cpp, that include a CPU core number determining function. It used to be in ParallelJobsGeneric.h/cpp before.
Attachments
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp
(17.18 KB, patch)
2012-01-18 04:48 PST
,
Roland Takacs
no flags
Details
Formatted Diff
Diff
I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)"
(17.34 KB, patch)
2012-01-18 06:20 PST
,
Roland Takacs
rtakacs
: review-
rtakacs
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Roland Takacs
Comment 1
2012-01-18 04:48:13 PST
Created
attachment 122902
[details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp "determineMaxNumberOfParallelThreads()" has been renamed to "NumberOfProcessorCores()".
Zoltan Herczeg
Comment 2
2012-01-18 04:54:01 PST
Comment on
attachment 122902
[details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp r=me
Raphael Kubo da Costa (:rakuco)
Comment 3
2012-01-18 05:37:46 PST
Comment on
attachment 122902
[details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp View in context:
https://bugs.webkit.org/attachment.cgi?id=122902&action=review
> Source/JavaScriptCore/wtf/NumberOfCores.cpp:29 > +#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)
Note you also need to add || OS(FREEBSD) here as you use it below, or the build will break on it.
Roland Takacs
Comment 4
2012-01-18 06:13:22 PST
Thanks for warning me, I have fixed it. (In reply to
comment #3
)
> (From update of
attachment 122902
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=122902&action=review
> > > Source/JavaScriptCore/wtf/NumberOfCores.cpp:29 > > +#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD) > > Note you also need to add || OS(FREEBSD) here as you use it below, or the build will break on it.
WebKit Review Bot
Comment 5
2012-01-18 06:15:24 PST
Comment on
attachment 122902
[details]
I moved the cross-platform CPU core counter to a new file from ParallelJobsGeneric.cpp Clearing flags on attachment: 122902 Committed
r105270
: <
http://trac.webkit.org/changeset/105270
>
WebKit Review Bot
Comment 6
2012-01-18 06:15:29 PST
All reviewed patches have been landed. Closing bug.
Roland Takacs
Comment 7
2012-01-18 06:20:40 PST
Created
attachment 122914
[details]
I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)"
Csaba Osztrogonác
Comment 8
2012-01-18 07:22:26 PST
Qt Windows (cross-MinGW) buildfix landed in
http://trac.webkit.org/changeset/105273
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug