RESOLVED FIXED 76529
[GTK] Listen to GDK_SCROLL_MASK 
https://bugs.webkit.org/show_bug.cgi?id=76529
Summary [GTK] Listen to GDK_SCROLL_MASK
Carlos Garnacho
Reported 2012-01-18 03:54:27 PST
There's a funny misbehavior in GTK+ where it sends scroll events to widgets listening to GDK_BUTTON_PRESS_MASK (perhaps dates from the old days where apps listened to 4-7 button presses), WebKitWebView seems to rely on this behavior and doesn't set GDK_SCROLL_MASK in the event mask, given it already seems to handle scroll events, adding this bit to the mask should be quite harmless, mostly for correctness
Attachments
Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base] (2.95 KB, patch)
2012-01-18 09:31 PST, Carlos Garnacho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-01-18 03:59:52 PST
GtkLayout adds EXPOSURE and SCROLL. It seems that when we switched from GtkLayout to GtkContainer EXPOSURE was added but not SCROLL, I don't know if that was on purpose, though.
Carlos Garnacho
Comment 2 2012-01-18 09:31:21 PST
Created attachment 122944 [details] Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base]
WebKit Review Bot
Comment 3 2012-01-18 09:37:43 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Review Bot
Comment 4 2012-01-18 10:07:09 PST
Comment on attachment 122944 [details] Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base] Clearing flags on attachment: 122944 Committed r105289: <http://trac.webkit.org/changeset/105289>
WebKit Review Bot
Comment 5 2012-01-18 10:07:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.