Bug 76529 - [GTK] Listen to GDK_SCROLL_MASK
Summary: [GTK] Listen to GDK_SCROLL_MASK
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-01-18 03:54 PST by Carlos Garnacho
Modified: 2012-01-18 10:07 PST (History)
4 users (show)

See Also:

Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base] (2.95 KB, patch)
2012-01-18 09:31 PST, Carlos Garnacho
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garnacho 2012-01-18 03:54:27 PST
There's a funny misbehavior in GTK+ where it sends scroll events to widgets listening to GDK_BUTTON_PRESS_MASK (perhaps dates from the old days where apps listened to 4-7 button presses), WebKitWebView seems to rely on this behavior and doesn't set GDK_SCROLL_MASK in the event mask, given it already seems to handle scroll events, adding this bit to the mask should be quite harmless, mostly for correctness
Comment 1 Carlos Garcia Campos 2012-01-18 03:59:52 PST
GtkLayout adds EXPOSURE and SCROLL. It seems that when we switched from GtkLayout to GtkContainer EXPOSURE was added but not SCROLL, I don't know if that was on purpose, though.
Comment 2 Carlos Garnacho 2012-01-18 09:31:21 PST
Created attachment 122944 [details]
Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base]
Comment 3 WebKit Review Bot 2012-01-18 09:37:43 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 WebKit Review Bot 2012-01-18 10:07:09 PST
Comment on attachment 122944 [details]
Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base]

Clearing flags on attachment: 122944

Committed r105289: <http://trac.webkit.org/changeset/105289>
Comment 5 WebKit Review Bot 2012-01-18 10:07:13 PST
All reviewed patches have been landed.  Closing bug.