RESOLVED FIXED 76510
check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports 
https://bugs.webkit.org/show_bug.cgi?id=76510
Summary check-webkit-style of the chromium test_expectations.txt file doesn't test al...
Ojan Vafai
Reported 2012-01-17 18:31:49 PST
check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
Attachments
Patch (8.51 KB, patch)
2012-01-17 18:33 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (5.74 KB, patch)
2012-01-18 14:22 PST, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-01-17 18:33:04 PST
Created attachment 122858 [details] Patch
Adam Barth
Comment 2 2012-01-17 18:43:24 PST
Comment on attachment 122858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122858&action=review > Tools/Scripts/webkitpy/style/checkers/test_expectations.py:61 > + if "chromium" in name: This doesn't seem like the right design. Are we missing a concept here?
Ojan Vafai
Comment 3 2012-01-18 14:05:14 PST
Comment on attachment 122858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122858&action=review >> Tools/Scripts/webkitpy/style/checkers/test_expectations.py:61 >> + if "chromium" in name: > > This doesn't seem like the right design. Are we missing a concept here? Yes. This patch is totally wrong. Will post a new one soon.
Ojan Vafai
Comment 4 2012-01-18 14:22:55 PST
Created attachment 122995 [details] Patch
Adam Barth
Comment 5 2012-01-19 14:50:43 PST
Comment on attachment 122995 [details] Patch This looks much better. Thanks!
Ojan Vafai
Comment 6 2012-01-19 15:01:35 PST
Committed r105452: <http://trac.webkit.org/changeset/105452>
Note You need to log in before you can comment on or make changes to this bug.