[chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
Created attachment 122854 [details] Patch
Tony, can you take a look at this?
I thought we couldn't use Tools/Tools.gyp because that's not checked out by the svn bots. DEPS only pulls in WebKit/Tools/DumpRenderTree and WebKit/Tools/Scripts. Can we make it WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp?
Oh, yeah, you're right. Sigh, leave things for a month and you forget everything; I was thinking it was just because of the gyp issue we found (and fixed) w/ relative paths. I will switch to a DumpRenderTree.gyp as you suggest.
Created attachment 122992 [details] move Tools/Tools.gyp to Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp, also change buildChromium()
Comment on attachment 122992 [details] move Tools/Tools.gyp to Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp, also change buildChromium() View in context: https://bugs.webkit.org/attachment.cgi?id=122992&action=review Please watch the bots when landing. > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:37 > + # FIXME: Remove this conditional check once chromium's > + # build/common.gypi is setting this flag to 0 by default. See Weird indent.
Committed r105330: <http://trac.webkit.org/changeset/105330>
From http://code.google.com/p/chromium/wiki/MacBuildInstructions, "To build just DumpRenderTree" cd ~/chromium/src xcodebuild -project third_party/WebKit/Source/WebKit/chromium/WebKit.xcodeproj -configuration Debug -target DumpRenderTree No longer works.
% xcodebuild -project third_party/WebKit/Source/WebKit/chromium/All.xcodeproj -list Targets: all_webkit (Active) Build Configurations: Debug (Active) Release workaround: build the "all_webkit" target (it's the default so it is optional as an argument), and that seems to produce DumpRenderTree.app. % xcodebuild -project third_party/WebKit/Source/WebKit/chromium/All.xcodeproj -configuration {Release|Debug} [-target all_webkit]
(In reply to comment #8) > From http://code.google.com/p/chromium/wiki/MacBuildInstructions, "To build just DumpRenderTree" > > cd ~/chromium/src > xcodebuild -project third_party/WebKit/Source/WebKit/chromium/WebKit.xcodeproj -configuration Debug -target DumpRenderTree > > No longer works. xcodebuild -project third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.xcodeproj -configuration Debug -target DumpRenderTree should work. I've updated the wiki. If you find that that doesn't work or something works better, feel free to update the wiki.
Yup, either All.xcodeproj or DumpRenderTree.xcodeproj should work. The whole point of these changes is to get that target out of WebKit.xcodeproj :). I missed updating the docs, though. Thanks for catching this and thanks Tony for updating them.
> > xcodebuild -project third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.xcodeproj -configuration Debug -target DumpRenderTree > > should work. I've updated the wiki. If you find that that doesn't work or something works better, feel free to update the wiki. > I clean built chrome-mac, then tried that command - it rebuilt all the .idl files, that makes the initial DumpRenderTree compile/build time is very long (comparable to building a clean chrome).