Bug 76500 - IndexedDB: Check for permission before using IndexedDB from a worker.
Summary: IndexedDB: Check for permission before using IndexedDB from a worker.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 17:11 PST by David Grogan
Modified: 2012-01-18 14:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.23 KB, patch)
2012-01-17 17:35 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Patch for landing (6.21 KB, patch)
2012-01-18 13:20 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-01-17 17:11:52 PST 
IndexedDB: Check for permission before using IndexedDB from a worker.
Comment 1 David Grogan 2012-01-17 17:35:26 PST 
Created attachment 122848 [details]
Patch
Comment 2 David Grogan 2012-01-17 17:40:50 PST 
Dave Levin - could you review?

This patch has updated parts of https://bugs.webkit.org/show_bug.cgi?id=73609 that I had pulled out.  There are some comments in the code explaining why I think this is thread-safe, but the WebCore::AllowCrossThreadAccess call still feels gross.
Comment 3 David Levin 2012-01-17 21:03:42 PST 
Comment on attachment 122848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122848&action=review

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:115
> +            m_webWorkerClientImpl->postTaskForModeToWorkerContext(

No new line needed here but if you add one then you need {} for this.

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:136
> +          bridge->signalCompleted(false, mode);

indentation isn't correct.
Comment 4 David Grogan 2012-01-18 13:20:33 PST 
Created attachment 122978 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-18 14:39:34 PST 
Comment on attachment 122978 [details]
Patch for landing

Clearing flags on attachment: 122978

Committed r105324: <http://trac.webkit.org/changeset/105324>
Comment 6 WebKit Review Bot 2012-01-18 14:39:39 PST 
All reviewed patches have been landed.  Closing bug.