RESOLVED FIXED 76500
IndexedDB: Check for permission before using IndexedDB from a worker. 
https://bugs.webkit.org/show_bug.cgi?id=76500
Summary IndexedDB: Check for permission before using IndexedDB from a worker.
David Grogan
Reported 2012-01-17 17:11:52 PST
IndexedDB: Check for permission before using IndexedDB from a worker.
Attachments
Patch (6.23 KB, patch)
2012-01-17 17:35 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.21 KB, patch)
2012-01-18 13:20 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-01-17 17:35:26 PST
Created attachment 122848 [details] Patch
David Grogan
Comment 2 2012-01-17 17:40:50 PST
Dave Levin - could you review? This patch has updated parts of https://bugs.webkit.org/show_bug.cgi?id=73609 that I had pulled out. There are some comments in the code explaining why I think this is thread-safe, but the WebCore::AllowCrossThreadAccess call still feels gross.
David Levin
Comment 3 2012-01-17 21:03:42 PST
Comment on attachment 122848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122848&action=review > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:115 > + m_webWorkerClientImpl->postTaskForModeToWorkerContext( No new line needed here but if you add one then you need {} for this. > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:136 > + bridge->signalCompleted(false, mode); indentation isn't correct.
David Grogan
Comment 4 2012-01-18 13:20:33 PST
Created attachment 122978 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-18 14:39:34 PST
Comment on attachment 122978 [details] Patch for landing Clearing flags on attachment: 122978 Committed r105324: <http://trac.webkit.org/changeset/105324>
WebKit Review Bot
Comment 6 2012-01-18 14:39:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.