Bug 76499 - [EFL] Use static const insted of #define macro.
Summary: [EFL] Use static const insted of #define macro.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 17:04 PST by Gyuyoung Kim
Modified: 2012-01-17 20:28 PST (History)
4 users (show)

See Also:


Attachments
Patch (11.54 KB, patch)
2012-01-17 17:05 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.51 KB, patch)
2012-01-17 18:54 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-01-17 17:04:26 PST
WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro. This patch replace global variables defined by #define with const. const keyword can make very slight performance hit. I think we can ignore it.
Comment 1 Gyuyoung Kim 2012-01-17 17:05:44 PST
Created attachment 122840 [details]
Patch
Comment 2 Hajime Morrita 2012-01-17 18:29:30 PST
Comment on attachment 122840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122840&action=review

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:37
> +static const int defaultTileHeigth = 256;

It looks this should be just const int, without static. Static is for static variables, which are usually staying inside c/cpp file.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:39
> +static const float zoomStepMinimum = 0.01;

Ditto.
Comment 3 Gyuyoung Kim 2012-01-17 18:54:55 PST
Created attachment 122863 [details]
Patch
Comment 4 WebKit Review Bot 2012-01-17 20:28:53 PST
Comment on attachment 122863 [details]
Patch

Clearing flags on attachment: 122863

Committed r105240: <http://trac.webkit.org/changeset/105240>
Comment 5 WebKit Review Bot 2012-01-17 20:28:58 PST
All reviewed patches have been landed.  Closing bug.