WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro. This patch replace global variables defined by #define with const. const keyword can make very slight performance hit. I think we can ignore it.
Created attachment 122840 [details] Patch
Comment on attachment 122840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122840&action=review > Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:37 > +static const int defaultTileHeigth = 256; It looks this should be just const int, without static. Static is for static variables, which are usually staying inside c/cpp file. > Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:39 > +static const float zoomStepMinimum = 0.01; Ditto.
Created attachment 122863 [details] Patch
Comment on attachment 122863 [details] Patch Clearing flags on attachment: 122863 Committed r105240: <http://trac.webkit.org/changeset/105240>
All reviewed patches have been landed. Closing bug.