Bug 76494 - Mac fails to fire an 'error' event for a <video> <source> having an URL with no file extension
Summary: Mac fails to fire an 'error' event for a <video> <source> having an URL with ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: MakingBotsRed
Depends on:
Blocks:
 
Reported: 2012-01-17 16:38 PST by Simon Fraser (smfr)
Modified: 2012-01-18 08:39 PST (History)
4 users (show)

See Also:


Attachments
Testcase (789 bytes, text/html)
2012-01-17 16:38 PST, Simon Fraser (smfr)
no flags Details
Patch (4.10 KB, patch)
2012-01-17 17:12 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (4.13 KB, patch)
2012-01-17 17:16 PST, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-01-17 16:38:21 PST
Created attachment 122837 [details]
Testcase

The compositing/video/video-with-invalid-source.html test times out on Mac because no error event is fired.
Comment 1 Jer Noble 2012-01-17 17:12:50 PST
Created attachment 122844 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-01-17 17:15:04 PST
Comment on attachment 122844 [details]
Patch

r=me but please add a test in media/ for this. In another bug I change the compositing test.
Comment 3 Jer Noble 2012-01-17 17:16:15 PST
Created attachment 122845 [details]
Patch

Rebased & should apply to ToT.
Comment 4 Alexey Proskuryakov 2012-01-17 18:50:25 PST
What's invalid about this URL? It seems perfectly valid, just missing on server.
Comment 5 James Robinson 2012-01-17 18:53:12 PST
That's the issue - even if nothing is there on the server no error event is fired.  The layout test in question tried to set src to "notarealsource", but no error event was ever fired in safari or in mac DRT
Comment 6 Eric Carlson 2012-01-17 20:13:58 PST
(In reply to comment #5)
> That's the issue - even if nothing is there on the server no error event is fired.  The layout test 
> in question tried to set src to "notarealsource", but no error event was ever fired in safari or 
> in mac DRT

Actually the problem is not that the file doesn't exist, the problem is that the url has no MIME type or extension so MediaPlayer can't find a media engine to use. If it did have a type or extension and there was a media registered for the type, MediaPlayer would ask it to load the url and it would return an error when it figured out that the file didn't exist.
Comment 7 Alexey Proskuryakov 2012-01-17 20:59:32 PST
It would be helpful to have bug title and ChangeLog changed accordingly. We have enough trouble with actual invalid KURLs...
Comment 8 Jer Noble 2012-01-18 08:39:16 PST
Committed r105279: <http://trac.webkit.org/changeset/105279>