Bug 76490 – Missing NSForegroundColorAttributeName should be treated as black instead of transparent

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

The problem appears in Mail on Lion using the Fonts and Colors palette to customize colors and fonts.

* STEPS TO REPRODUCE
1. Create new message, write some text.
2. Select text, use color picker to change color to a color other than black.
3. With text still selected, use color picker to change color to black.

* RESULTS
Text becomes invisible/transparent. It should be black.

* REGRESSION
The Fonts and Color palette work as expected in previous version of Mac OSX.

[Enrica Casucci]

<rdar://problem/9460733>

[Enrica Casucci]

AppKit's behavior changed in Lion. If the NSForegroundColorAttributeName is solid black, it is removed from the attributes dictionary. WebKit used to treat the missing color as an indication of transparent color.

[Enrica Casucci]

Created attachment 122833 [details]
Patch

[Enrica Casucci]

Thanks for the review!
Dan pointed out that I should write a TestWebKitAPI test and has shown me how to do it.
I'll post another patch that has the test.

[Enrica Casucci]

Created attachment 122856 [details]
Patch with test

Comment on attachment 122856 [details]
Patch with test

View in context: https://bugs.webkit.org/attachment.cgi?id=122856&action=review

> Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm:28
> +#import <WebKit/DOMPrivate.h>

Is thIs needed?

[Enrica Casucci]

(In reply to comment #6)
> (From update of attachment 122856 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122856&action=review
> 
> > Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm:28
> > +#import <WebKit/DOMPrivate.h>
> 
> Is thIs needed?

No, I've removed it. Thanks for pointing it out.

[Enrica Casucci]

http://trac.webkit.org/changeset/105291

[Eric Vitiello]

Just wanted to say thanks for fixing this. it drives me nuts.