Bug 76484 - Check style on test_expectations.txt files before commit
Summary: Check style on test_expectations.txt files before commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 15:33 PST by Ojan Vafai
Modified: 2013-07-17 02:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.00 KB, patch)
2012-01-17 15:49 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (5.71 KB, patch)
2012-01-18 14:21 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-17 15:33:10 PST
Check style on test_expectations.txt files before commit
Comment 1 Ojan Vafai 2012-01-17 15:49:36 PST
Created attachment 122829 [details]
Patch
Comment 2 Adam Barth 2012-01-17 16:24:17 PST
Comment on attachment 122829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122829&action=review

Nice approach.  Thanks.

> Tools/Scripts/webkitpy/tool/steps/commit.py:60
> +        if not len(test_expectations_files):
> +            return

You can just say:

if not test_expectations_files:

the empty list is falsy.
Comment 3 Ojan Vafai 2012-01-17 16:41:18 PST
Committed r105213: <http://trac.webkit.org/changeset/105213>
Comment 4 Ojan Vafai 2012-01-18 14:21:03 PST
Reopening to attach new patch.
Comment 5 Ojan Vafai 2012-01-18 14:21:06 PST
Created attachment 122993 [details]
Patch
Comment 6 Ojan Vafai 2012-01-18 14:22:02 PST
Comment on attachment 122993 [details]
Patch

Whoops. Wrong bug...
Comment 7 Brian Holt 2013-07-17 01:43:35 PDT
(In reply to comment #6)
> (From update of attachment 122993 [details])
> Whoops. Wrong bug...

Was this bug was reopened incorrectly? Can we close it?
Comment 8 Zan Dobersek 2013-07-17 02:05:01 PDT
I think so.