Bug 76481 - webkitpy: fix json import in json_results_generator_unittest.py
Summary: webkitpy: fix json import in json_results_generator_unittest.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 14:48 PST by Dirk Pranke
Modified: 2012-01-17 18:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.11 KB, patch)
2012-01-17 14:49 PST, Dirk Pranke
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-01-17 14:48:33 PST
webkitpy: fix json import on linux
Comment 1 Dirk Pranke 2012-01-17 14:49:33 PST
Created attachment 122816 [details]
Patch
Comment 2 Dirk Pranke 2012-01-17 15:08:35 PST
ick ... okay, the distribution of python on my linux box seems to point to some glacially old version of simplejson that does actually have a speedups.so compiled, so when we load the version in thirdparty/simplejson, it picks up an old speedups.so and explodes.

Note that the import in simplejson/encoder.py is "from simplejson import _speedups"; since our module is known as "webkitpy.thirdparty.simplejson" this is how we end up getting the wrong version here.

importing json directly is probably the right way to avoid this version skew.
Comment 3 Dirk Pranke 2012-01-17 15:10:56 PST
Committed r105199: <http://trac.webkit.org/changeset/105199>
Comment 4 Eric Seidel (no email) 2012-01-17 18:46:42 PST
We're about to remove support for 2.5 anyway. :)