Bug 76477 - add test expections ahead of skia DEPS roll
Summary: add test expections ahead of skia DEPS roll
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 13:20 PST by Mike Reed
Modified: 2012-01-18 12:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.22 KB, patch)
2012-01-17 13:23 PST, Mike Reed
no flags Details | Formatted Diff | Diff
Patch (3.14 KB, patch)
2012-01-18 06:52 PST, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2012-01-17 13:20:39 PST
add test expections ahead of skia DEPS roll
Comment 1 Mike Reed 2012-01-17 13:23:33 PST
Created attachment 122804 [details]
Patch
Comment 2 Stephen White 2012-01-17 14:16:58 PST
Comment on attachment 122804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122804&action=review

r=me, but a comment would be nice.

> LayoutTests/platform/chromium/test_expectations.txt:1111
> +//BUGCR105305 MAC : fast/borders/border-image-rotate-transform.html = IMAGE

Probably should add a comment here explaining why it's commented out.  Is it still expected to be wrong after the skia roll?  Or just wrong in a new way?  If neither, it should just be removed.
Comment 3 WebKit Review Bot 2012-01-18 05:01:33 PST
Comment on attachment 122804 [details]
Patch

Rejecting attachment 122804 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

NOBODY just expectations changes found in /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11282176
Comment 4 Mike Reed 2012-01-18 06:52:52 PST
Created attachment 122919 [details]
Patch
Comment 5 Mike Reed 2012-01-18 06:56:44 PST
addressed comment in #2, added "Unreviewed" to ChangeLog
Comment 6 Stephen White 2012-01-18 09:38:50 PST
Comment on attachment 122919 [details]
Patch

Looks good.  r=me
Comment 7 WebKit Review Bot 2012-01-18 11:59:56 PST
Comment on attachment 122919 [details]
Patch

Clearing flags on attachment: 122919

Committed r105304: <http://trac.webkit.org/changeset/105304>
Comment 8 WebKit Review Bot 2012-01-18 12:00:00 PST
All reviewed patches have been landed.  Closing bug.