WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76471
Move RunLoop to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=76471
Summary
Move RunLoop to WebCore/platform
Sam Weinig
Reported
2012-01-17 12:09:25 PST
Move RunLoop to WebCore/platform
Attachments
Patch
(127.12 KB, patch)
2012-01-17 12:10 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(127.36 KB, patch)
2012-01-17 18:37 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(127.95 KB, patch)
2012-01-18 13:46 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(125.44 KB, patch)
2012-01-18 14:05 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(125.60 KB, patch)
2012-01-18 16:47 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(126.16 KB, patch)
2012-01-19 10:14 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(126.18 KB, patch)
2012-01-19 11:36 PST
,
Sam Weinig
andersca
: review+
gustavo.noronha
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2012-01-17 12:10:09 PST
Created
attachment 122796
[details]
Patch
WebKit Review Bot
Comment 2
2012-01-17 13:15:44 PST
Attachment 122796
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/WebProcess/win/WebProcessMainWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Platform/CoreIPC/Connection.h:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/platform/qt/RunLoopQt.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/RunLoopQt.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/RunLoopQt.cpp:38: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/PluginProcess/PluginProcess.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/Launcher/win/ThreadLauncherWin.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 11 in 62 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3
2012-01-17 13:27:15 PST
Comment on
attachment 122796
[details]
Patch
Attachment 122796
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/11111303
Gustavo Noronha (kov)
Comment 4
2012-01-17 13:44:16 PST
Comment on
attachment 122796
[details]
Patch
Attachment 122796
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11268315
Sam Weinig
Comment 5
2012-01-17 18:37:12 PST
Created
attachment 122859
[details]
Patch
Gustavo Noronha (kov)
Comment 6
2012-01-17 22:50:08 PST
Comment on
attachment 122859
[details]
Patch
Attachment 122859
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11283088
Sam Weinig
Comment 7
2012-01-18 13:46:48 PST
Created
attachment 122984
[details]
Patch
Sam Weinig
Comment 8
2012-01-18 14:05:26 PST
Created
attachment 122990
[details]
Patch
Gustavo Noronha (kov)
Comment 9
2012-01-18 14:45:34 PST
Comment on
attachment 122990
[details]
Patch
Attachment 122990
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11196842
Sam Weinig
Comment 10
2012-01-18 16:47:34 PST
Created
attachment 123037
[details]
Patch
Gustavo Noronha (kov)
Comment 11
2012-01-18 21:20:49 PST
Comment on
attachment 123037
[details]
Patch
Attachment 123037
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11284500
Sam Weinig
Comment 12
2012-01-19 10:14:06 PST
Created
attachment 123146
[details]
Patch
Gustavo Noronha (kov)
Comment 13
2012-01-19 10:19:55 PST
Comment on
attachment 123146
[details]
Patch
Attachment 123146
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11132152
Sam Weinig
Comment 14
2012-01-19 11:36:55 PST
Created
attachment 123157
[details]
Patch
Collabora GTK+ EWS bot
Comment 15
2012-01-19 17:53:23 PST
Comment on
attachment 123157
[details]
Patch
Attachment 123157
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11247264
Gustavo Noronha (kov)
Comment 16
2012-01-19 18:24:32 PST
Comment on
attachment 123157
[details]
Patch
Attachment 123157
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/11253646
Sam Weinig
Comment 17
2012-01-19 19:05:11 PST
Committed
r105475
: <
http://trac.webkit.org/changeset/105475
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug