RESOLVED FIXED76469
[SKIA / CHROMIUM] Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu 
https://bugs.webkit.org/show_bug.cgi?id=76469
Summary [SKIA / CHROMIUM] Add some canvas tests to test_expectations to prepare for c...
Brian Salomon
Reported 2012-01-17 11:48:09 PST
Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu
Attachments
Patch (3.33 KB, patch)
2012-01-17 11:49 PST, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2012-01-18 07:15 PST, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2012-01-19 08:13 PST, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2012-01-17 11:49:07 PST
Created attachment 122793 [details] Patch
Brian Salomon
Comment 2 2012-01-17 11:52:22 PST
These tests break in DRT when using the sw rasterizer for paths. I noticed that the downstream test_expectations is not respected for --platform chromium-gpu so instead I'm modifying upstream in advance. Is that a known issue or should I file a chromium bug?
Stephen White
Comment 3 2012-01-17 12:04:28 PST
(In reply to comment #2) > These tests break in DRT when using the sw rasterizer for paths. I noticed that the downstream test_expectations is not respected for --platform chromium-gpu so instead I'm modifying upstream in advance. Is that a known issue or should I file a chromium bug?
Stephen White
Comment 4 2012-01-17 12:07:10 PST
(In reply to comment #3) > (In reply to comment #2) > > These tests break in DRT when using the sw rasterizer for paths. I noticed that the downstream test_expectations is not respected for --platform chromium-gpu so instead I'm modifying upstream in advance. Is that a known issue or should I file a chromium bug? It's working as intended. It is designed to make the WebKit gardener's job easier, since they can tell more easily just by looking at the canaries/trybots if the upstream test_expectations are correct (without being masked by downstream t_e changes). It makes the life of the Skia gardener more difficult, though. Our usual policy has been to land upstream suppressions preemptively, as you're doing here.
Stephen White
Comment 5 2012-01-17 12:08:38 PST
Comment on attachment 122793 [details] Patch OK. r=me
Brian Salomon
Comment 6 2012-01-17 12:12:27 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > These tests break in DRT when using the sw rasterizer for paths. I noticed that the downstream test_expectations is not respected for --platform chromium-gpu so instead I'm modifying upstream in advance. Is that a known issue or should I file a chromium bug? > > It's working as intended. It is designed to make the WebKit gardener's job easier, since they can tell more easily just by looking at the canaries/trybots if the upstream test_expectations are correct (without being masked by downstream t_e changes). It makes the life of the Skia gardener more difficult, though. > > Our usual policy has been to land upstream suppressions preemptively, as you're doing here. Got it. Thanks for the clarification!
WebKit Review Bot
Comment 7 2012-01-17 13:44:02 PST
Comment on attachment 122793 [details] Patch Clearing flags on attachment: 122793 Committed r105191: <http://trac.webkit.org/changeset/105191>
WebKit Review Bot
Comment 8 2012-01-17 13:44:07 PST
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 9 2012-01-17 15:32:16 PST
This patch had bad (duplicate) expectations for fast/canvas/image-object-in-canvas.html and fast/canvas/image-pattern-rotate.html. Please lint test_expectation.txt changes by running: new-run-webkit-tests --lint-test-files and fix any errors it reports before landing
Brian Salomon
Comment 10 2012-01-18 07:15:51 PST
Reopening to attach new patch.
Brian Salomon
Comment 11 2012-01-18 07:15:55 PST
Created attachment 122923 [details] Patch
Brian Salomon
Comment 12 2012-01-18 07:18:50 PST
So sorry about the conflicts. The new patch adds the conflicting fast/canvas tests back to all GPU configs and removes conflicting LEOPARD GPU entries. Also, the four philip tests fail on mac so I've removed WIN LINUX tags. It passes the lint checker.
Stephen White
Comment 13 2012-01-18 13:36:34 PST
Comment on attachment 122923 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 14 2012-01-18 14:27:56 PST
Comment on attachment 122923 [details] Patch Clearing flags on attachment: 122923 Committed r105320: <http://trac.webkit.org/changeset/105320>
WebKit Review Bot
Comment 15 2012-01-18 14:28:02 PST
All reviewed patches have been landed. Closing bug.
Brian Salomon
Comment 16 2012-01-19 08:13:25 PST
Reopening to attach new patch.
Brian Salomon
Comment 17 2012-01-19 08:13:29 PST
Created attachment 123132 [details] Patch
Brian Salomon
Comment 18 2012-01-19 08:15:06 PST
There is one more test to add to this list: arc360.html. The latest patch adds it to test_expectations.
Stephen White
Comment 19 2012-01-19 08:40:40 PST
Comment on attachment 123132 [details] Patch OK. r=me
WebKit Review Bot
Comment 20 2012-01-19 15:34:18 PST
Comment on attachment 123132 [details] Patch Clearing flags on attachment: 123132 Committed r105455: <http://trac.webkit.org/changeset/105455>
WebKit Review Bot
Comment 21 2012-01-19 15:34:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.