WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76467
[Mac] Add a flag telling plug-in if it can enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=76467
Summary
[Mac] Add a flag telling plug-in if it can enter sandbox
Alexey Proskuryakov
Reported
2012-01-17 11:38:12 PST
A plug-in cannot know if it's running in a process that would tolerate entering sandbox. Let's tell it (a Mac only experiment for now).
Attachments
proposed patch
(1.71 KB, patch)
2012-01-17 11:39 PST
,
Alexey Proskuryakov
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2012-01-17 11:39:40 PST
Created
attachment 122789
[details]
proposed patch
Anders Carlsson
Comment 2
2012-01-17 12:10:16 PST
Comment on
attachment 122789
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=122789&action=review
> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:503 > + case WKNVAllowedToEnterSandbox: > + *(NPBool*)value = true; > + break;
Shouldn't this be true only when running in the plug-in process? (Not that it really matters since we don't support in-process plug-ins with WebKit2).
Alexey Proskuryakov
Comment 3
2012-01-17 12:17:02 PST
> we don't support in-process plug-ins with WebKit2
Yes, this is why I made it always return true. Was there a better way to write this?
Alexey Proskuryakov
Comment 4
2012-03-07 16:13:54 PST
This has been landed long ago in <
http://trac.webkit.org/changeset/105323
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug