Bug 76457 - Web Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
Summary: Web Inspector: track HTML revisions when editing DOM and / or upon free flow ...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 08:20 PST by Pavel Feldman
Modified: 2014-12-12 13:14 PST (History)
11 users (show)

See Also:


Attachments
Patch (24.16 KB, patch)
2012-01-18 02:30 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-01-17 08:20:57 PST
This feature is still behind the experimental flag.
Comment 1 Pavel Feldman 2012-01-18 02:30:12 PST
Created attachment 122892 [details]
Patch
Comment 2 Pavel Feldman 2012-01-18 04:53:12 PST
Committed r105262: <http://trac.webkit.org/changeset/105262>
Comment 3 Csaba Osztrogonác 2012-01-18 07:36:27 PST
Reopen, because inspector/elements/set-html-via-resource.html is broken on SL and on Qt:

--- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/inspector/elements/set-html-via-resource-expected.txt 
+++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/inspector/elements/set-html-via-resource-actual.txt 
@@ -1,5 +1,16 @@
-Tests that the DOM content can be set via editing resource content.
-
-
-<html><head></head><body>New iframe content</body></html>
-
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderBlock {P} at (0,0) size 784x18
+        RenderText {#text} at (0,0) size 422x18
+          text run at (0,0) width 422: "Tests that the DOM content can be set via editing resource content."
+      RenderBlock (anonymous) at (0,34) size 784x154
+        RenderPartObject {IFRAME} at (0,0) size 304x154 [border: (2px inset #000000)]
+          layer at (0,0) size 300x150
+            RenderView at (0,0) size 300x150
+          layer at (0,0) size 300x150
+            RenderBlock {HTML} at (0,0) size 300x150
+              RenderBody {BODY} at (8,8) size 284x134
+        RenderText {#text} at (0,0) size 0x0

Could you check and fix it?
Comment 4 Timothy Hatcher 2012-01-18 07:47:27 PST
Comment on attachment 122892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122892&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:1168
> +            DOMAgent.querySelectorAll(doc.id, "iframe[src]", setOuterHTML.bind(this, true));

What about "frame[src]"? tivofaq.com is a good example.
Comment 5 Pavel Feldman 2012-01-18 07:52:24 PST
(In reply to comment #4)
> (From update of attachment 122892 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122892&action=review
> 
> > Source/WebCore/inspector/front-end/DOMAgent.js:1168
> > +            DOMAgent.querySelectorAll(doc.id, "iframe[src]", setOuterHTML.bind(this, true));
> 
> What about "frame[src]"? tivofaq.com is a good example.

I thought people don't use those anymore. I'll fix as a follow up. Thanks.
Comment 6 Csaba Osztrogonác 2012-01-18 09:20:32 PST
I skipped the failing test to paint the Qt bot green: http://trac.webkit.org/changeset/105283

Please unskip it when the fix lands.
Comment 7 Timothy Hatcher 2012-01-18 09:44:14 PST
Also how do you handle multiple frames using the same URL? It looks like that would cause weird results. Maybe you should include the frameId/requestId on the document node so you can know you have the right WebInspector.Resource?
Comment 8 Csaba Osztrogonác 2012-01-18 09:45:41 PST
(In reply to comment #6)
> I skipped the failing test to paint the Qt bot green: http://trac.webkit.org/changeset/105283
> 
> Please unskip it when the fix lands.

Fix landed in http://trac.webkit.org/changeset/105284. Thanks.