This feature is still behind the experimental flag.
Created attachment 122892 [details] Patch
Committed r105262: <http://trac.webkit.org/changeset/105262>
Reopen, because inspector/elements/set-html-via-resource.html is broken on SL and on Qt: --- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/inspector/elements/set-html-via-resource-expected.txt +++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/inspector/elements/set-html-via-resource-actual.txt @@ -1,5 +1,16 @@ -Tests that the DOM content can be set via editing resource content. - - -<html><head></head><body>New iframe content</body></html> - +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 + RenderBody {BODY} at (8,8) size 784x584 + RenderBlock {P} at (0,0) size 784x18 + RenderText {#text} at (0,0) size 422x18 + text run at (0,0) width 422: "Tests that the DOM content can be set via editing resource content." + RenderBlock (anonymous) at (0,34) size 784x154 + RenderPartObject {IFRAME} at (0,0) size 304x154 [border: (2px inset #000000)] + layer at (0,0) size 300x150 + RenderView at (0,0) size 300x150 + layer at (0,0) size 300x150 + RenderBlock {HTML} at (0,0) size 300x150 + RenderBody {BODY} at (8,8) size 284x134 + RenderText {#text} at (0,0) size 0x0 Could you check and fix it?
Comment on attachment 122892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122892&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:1168 > + DOMAgent.querySelectorAll(doc.id, "iframe[src]", setOuterHTML.bind(this, true)); What about "frame[src]"? tivofaq.com is a good example.
(In reply to comment #4) > (From update of attachment 122892 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122892&action=review > > > Source/WebCore/inspector/front-end/DOMAgent.js:1168 > > + DOMAgent.querySelectorAll(doc.id, "iframe[src]", setOuterHTML.bind(this, true)); > > What about "frame[src]"? tivofaq.com is a good example. I thought people don't use those anymore. I'll fix as a follow up. Thanks.
I skipped the failing test to paint the Qt bot green: http://trac.webkit.org/changeset/105283 Please unskip it when the fix lands.
Also how do you handle multiple frames using the same URL? It looks like that would cause weird results. Maybe you should include the frameId/requestId on the document node so you can know you have the right WebInspector.Resource?
(In reply to comment #6) > I skipped the failing test to paint the Qt bot green: http://trac.webkit.org/changeset/105283 > > Please unskip it when the fix lands. Fix landed in http://trac.webkit.org/changeset/105284. Thanks.