RESOLVED FIXED 76455
Web Inspector: Refactor JavaScriptOutlineDialog: extract FilteredItemSelectionDialog and reuse DialogDelegate. 
https://bugs.webkit.org/show_bug.cgi?id=76455
Summary Web Inspector: Refactor JavaScriptOutlineDialog: extract FilteredItemSelectio...
Vsevolod Vlasov
Reported 2012-01-17 07:50:41 PST
JavaScriptOutlineDialog should be based on Dialog/DialogDelegate.
Attachments
Patch (54.23 KB, patch)
2012-01-17 09:49 PST, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-01-17 08:06:33 PST
Refactor JavaScriptOutlineDialog: extract FilteredItemSelectionDialog and reuse DialogDelegate.
Vsevolod Vlasov
Comment 2 2012-01-17 09:49:47 PST
Created attachment 122779 [details] Patch
Yury Semikhatsky
Comment 3 2012-01-17 10:47:53 PST
Comment on attachment 122779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122779&action=review > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:38 > + WebInspector.DialogDelegate.call(this); It's a bit confusing that the FilteredItemSelectionDialog is itself a dialog delegate not a dialog descendant. > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:213 > + _filterFunctions: function() _filterFunctions -> _filterItems > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:431 > +WebInspector.FilteredItemSelectionDialogDelegate.prototype = { Maybe SelectionDialogContentProvider?
Vsevolod Vlasov
Comment 4 2012-01-17 11:00:31 PST
Committed r105171: <http://trac.webkit.org/changeset/105171>
Note You need to log in before you can comment on or make changes to this bug.