Bug 76439 - <content> should create HTMLContentElement object
Summary: <content> should create HTMLContentElement object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on: 76353
Blocks: 76434
  Show dependency tree / graph
 
Reported: 2012-01-17 01:44 PST by Shinya Kawanaka
Modified: 2012-01-26 09:03 PST (History)
14 users (show)

See Also:

Attachments
WIP (4.78 KB, patch)
2012-01-18 22:43 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
WIP (6.85 KB, patch)
2012-01-20 04:26 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
WIP (18.72 KB, patch)
2012-01-24 13:55 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (23.60 KB, patch)
2012-01-24 17:12 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (24.00 KB, patch)
2012-01-25 09:52 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-01-17 01:44:08 PST 
We should be able to parse <content select="..." ...>.
Comment 1 Hajime Morrita 2012-01-18 20:56:06 PST 
In this change I'll add
- HTMLContentElement
- content to HTMLNames.in
behind the flag.

The flag will be added in Bug 76353.
Comment 2 Hajime Morrita 2012-01-18 22:43:05 PST 
Created attachment 123075 [details]
WIP
Comment 3 Hajime Morrita 2012-01-20 04:26:11 PST 
Created attachment 123288 [details]
WIP
Comment 4 Hajime Morrita 2012-01-20 04:29:37 PST 
(In reply to comment #3)
> Created an attachment (id=123288) [details]
> WIP
It looks that the nested case doesn't work. I need to care about that.
Comment 5 Hajime Morrita 2012-01-24 13:55:35 PST 
Created attachment 123801 [details]
WIP
Comment 6 Hajime Morrita 2012-01-24 17:12:09 PST 
Created attachment 123849 [details]
Patch
Comment 7 Hajime Morrita 2012-01-24 17:13:02 PST 
Hi Dimitri, could you take a look at this? <content> is coming here.
Comment 8 WebKit Review Bot 2012-01-24 19:08:19 PST 
Comment on attachment 123849 [details]
Patch

Attachment 123849 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11344179

New failing tests:
media/audio-garbage-collect.html
Comment 9 Collabora GTK+ EWS bot 2012-01-25 04:03:56 PST 
Comment on attachment 123849 [details]
Patch

Attachment 123849 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11344493
Comment 10 Hajime Morrita 2012-01-25 09:52:12 PST 
Created attachment 123963 [details]
Patch for landing
Comment 11 WebKit Review Bot 2012-01-25 12:47:52 PST 
Comment on attachment 123963 [details]
Patch for landing

Clearing flags on attachment: 123963

Committed r105917: <http://trac.webkit.org/changeset/105917>
Comment 12 WebKit Review Bot 2012-01-25 12:47:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Csaba Osztrogonác 2012-01-26 00:58:29 PST 
Comment on attachment 123963 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=123963&action=review

> LayoutTests/platform/qt/test_expectations.txt:10
> +// Needs ENABLE_SHADOW_DOM
> +BUGWK76439 DEBUG : fast/dom/shadow/content-element-api.html = TEXT
> +BUGWK76439 DEBUG : fast/dom/shadow/content-element-outside-shadow.html = TEXT
> +

These tests fail in release mode too. And we use Skipped list 
to disable tests because of not yet supported features.

I landed the fix: http://trac.webkit.org/changeset/105973
Comment 14 Hajime Morrita 2012-01-26 09:01:45 PST 
(In reply to comment #13)
> 
> These tests fail in release mode too. And we use Skipped list 
> to disable tests because of not yet supported features.
> 
> I landed the fix: http://trac.webkit.org/changeset/105973
Oooopsss. Thanks much for your catch.
A series of my patches yesterday were totally broken...
Comment 15 Dimitri Glazkov (Google) 2012-01-26 09:03:22 PST 
(In reply to comment #14)
> (In reply to comment #13)
> > 
> > These tests fail in release mode too. And we use Skipped list 
> > to disable tests because of not yet supported features.
> > 
> > I landed the fix: http://trac.webkit.org/changeset/105973
> Oooopsss. Thanks much for your catch.
> A series of my patches yesterday were totally broken...

I blame the reviewer! :P Seriously, we must try to do better.