Bug 76421 – Add proper offset to position right click to simulate a context menu invocation.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Marc-André Decoste]

Add proper offset to position right click to simulate a context menu invokatioon.

[Marc-André Decoste]

Created attachment 122767 [details]
Patch

[Erik Arvidsson]

Comment on attachment 122767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122767&action=review

> Source/WebCore/page/EventHandler.cpp:2337
> +        // In a multiline edit, firstRect.maxY() would endup on the next line, so -1.
> +        int y = firstRect.maxY() ? firstRect.maxY() - 1 : 0;

I find this strange. Why does this only happen for multiline edit and not for other cases?

[Marc-André Decoste]

For the same reason that it currently works if you are on the last line of a multiline textarea, there is no other line underneath it and you endup sending the click in the border/gap area which you can try with right clicks and you will notice the difference...

[Ojan Vafai]

Comment on attachment 122767 [details]
Patch

Patch looks fine. Can you make a manual test in the ManualTests directory?

[Marc-André Decoste]

Created attachment 123211 [details]
Patch

[Marc-André Decoste]

Comment on attachment 123211 [details]
Patch

How about this for the manual test?

Thanks!

BYE
MAD

[Marc-André Decoste]

No, wait, I just realized I was in the wrong manual test folder...

And I also noticed that there are already ManualTests for the context menu, so I'll piggyback on those...

Another patch is coming...

Sorry...

[Marc-André Decoste]

Created attachment 123214 [details]
Patch

[Marc-André Decoste]

Comment on attachment 123214 [details]
Patch

OK, how about this now?

[WebKit Review Bot]

Comment on attachment 123214 [details]
Patch

Rejecting attachment 123214 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10408 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10408.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11311163

[Ojan Vafai]

Comment on attachment 123214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123214&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This line is what killed the commit queue. You can just delete it since you've added a manual test.

[Marc-André Decoste]

Created attachment 123356 [details]
Patch

[Marc-André Decoste]

Comment on attachment 123356 [details]
Patch

All good now?

Thanks!

[WebKit Review Bot]

Comment on attachment 123356 [details]
Patch

Clearing flags on attachment: 123356

Committed r105538: <http://trac.webkit.org/changeset/105538>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.