Bug 76403 - Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json
Summary: Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-16 13:05 PST by Peter Rybin
Modified: 2012-01-17 07:32 PST (History)
11 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2012-01-17 02:54 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (63.92 KB, patch)
2012-01-17 07:13 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2012-01-17 07:25 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-01-16 13:05:09 PST
Source/WebCore/inspector/ConsoleMessage.cpp:121
"other" is not declared as enum constant (C++ TypeBuilder::Console::ConsoleMessage::Type)

Source/WebCore/inspector/InspectorResourceAgent.cpp:179
"response" is not an optional field (in C++ TypeBuilder::Network::Response)
Comment 1 Yury Semikhatsky 2012-01-17 02:54:54 PST
Created attachment 122744 [details]
Patch
Comment 2 Pavel Feldman 2012-01-17 06:27:24 PST
Comment on attachment 122744 [details]
Patch

You should modify Inspector-0.1.json as well. I wonder why backwards compatibility check did not trigger.
Comment 3 Yury Semikhatsky 2012-01-17 07:13:36 PST
Created attachment 122763 [details]
Patch
Comment 4 Yury Semikhatsky 2012-01-17 07:15:23 PST
(In reply to comment #2)
> (From update of attachment 122744 [details])
> You should modify Inspector-0.1.json as well. I wonder why backwards compatibility check did not trigger.

Done. Filed a bug about the compatibility check: https://bugs.webkit.org/show_bug.cgi?id=76452
Comment 5 Pavel Feldman 2012-01-17 07:22:37 PST
Comment on attachment 122763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122763&action=review

> Source/WebCore/inspector/Inspector-0.1.json:1
>  {

The only change to the Inspector-0.1.json we accept are the ones where we know that the behavior of the tool on the date of the Inspector-0.1.json forking did not conform it already.

> Source/WebCore/inspector/Inspector-0.1.json:9
> +                "name": "enable",

Not all of the browsers supporting 0.1 have these methods, so you should not add them.
Comment 6 Yury Semikhatsky 2012-01-17 07:25:02 PST
Created attachment 122766 [details]
Patch
Comment 7 Yury Semikhatsky 2012-01-17 07:30:01 PST
Committed r105154: <http://trac.webkit.org/changeset/105154>
Comment 8 Yury Semikhatsky 2012-01-17 07:32:28 PST
Comment on attachment 122766 [details]
Patch

Clearing flags from landed patch.