Bug 76403 – Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Source/WebCore/inspector/ConsoleMessage.cpp:121
"other" is not declared as enum constant (C++ TypeBuilder::Console::ConsoleMessage::Type)

Source/WebCore/inspector/InspectorResourceAgent.cpp:179
"response" is not an optional field (in C++ TypeBuilder::Network::Response)

[Yury Semikhatsky]

Created attachment 122744 [details]
Patch

[Pavel Feldman]

Comment on attachment 122744 [details]
Patch

You should modify Inspector-0.1.json as well. I wonder why backwards compatibility check did not trigger.

[Yury Semikhatsky]

Created attachment 122763 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 122744 [details])
> You should modify Inspector-0.1.json as well. I wonder why backwards compatibility check did not trigger.

Done. Filed a bug about the compatibility check: https://bugs.webkit.org/show_bug.cgi?id=76452

[Pavel Feldman]

Comment on attachment 122763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122763&action=review

> Source/WebCore/inspector/Inspector-0.1.json:1
>  {

The only change to the Inspector-0.1.json we accept are the ones where we know that the behavior of the tool on the date of the Inspector-0.1.json forking did not conform it already.

> Source/WebCore/inspector/Inspector-0.1.json:9
> +                "name": "enable",

Not all of the browsers supporting 0.1 have these methods, so you should not add them.

[Yury Semikhatsky]

Created attachment 122766 [details]
Patch

[Yury Semikhatsky]

Committed r105154: <http://trac.webkit.org/changeset/105154>

[Yury Semikhatsky]

Comment on attachment 122766 [details]
Patch

Clearing flags from landed patch.