Bug 76396 – REGRESSION(r105072): It broke committers_unittest.py

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

We have one more Dan as committer, and unit test can't handle this situation:
http://trac.webkit.org/changeset/105072/trunk/Tools/Scripts/webkitpy/common/config/committers.py

Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/config/committers_unittest.py", line 170, in test_contributors_by_fuzzy_match_with_legacy_names
    self._assert_fuzz_match('Dan', 'Dan Bernstein', 0)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/config/committers_unittest.py", line 108, in _assert_fuzz_match
    self.assertEqual(([contributor.full_name for contributor in contributors], distance), (expected_names, expected_distance))
AssertionError: (['Dan Winship', 'Dan Bernstein'], 0) != (['Dan Bernstein'], 0)

[Csaba Osztrogonác]

Created attachment 122668 [details]
Patch

[Adam Barth]

Comment on attachment 122668 [details]
Patch

These tests seem poorly designed...

[Eric Seidel (no email)]

rniwa is the man behind these tests iirc.

[Csaba Osztrogonác]

Ooops, it isn't Qt specific, it was copy/paste error :)

[Dan Winship]

Oh, awesome. I broke the build on my first commit. :-O

(FWIW, I even ran committers_unittest.py, and it exited with status 0 without printing anything, so I figured I was good... guess I should have looked more carefully at the code.)

[Csaba Osztrogonác]

Comment on attachment 122668 [details]
Patch

Committed r105082

[Csaba Osztrogonác]

(In reply to comment #5)
> Oh, awesome. I broke the build on my first commit. :-O
> 
> (FWIW, I even ran committers_unittest.py, and it exited with status 0 without printing anything, so I figured I was good... guess I should have looked more carefully at the code.)

Not a problem, the test was bad now. (Otherwise we usually run Tools/Scripts/test-webkitpy instead of individual test)

[Eric Seidel (no email)]

(In reply to comment #5)
> Oh, awesome. I broke the build on my first commit. :-O
> 
> (FWIW, I even ran committers_unittest.py, and it exited with status 0 without printing anything, so I figured I was good... guess I should have looked more carefully at the code.)

Despite the existence of those __main__ blocks, that's not really a sanctioned way to run the tests.  test-webkitpy is your best bet.