Bug 76391 - Crash at WebCore::MediaControlRootElement::makeOpaque + 97
Summary: Crash at WebCore::MediaControlRootElement::makeOpaque + 97
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-16 09:52 PST by Jer Noble
Modified: 2012-01-19 10:53 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2012-01-16 09:57 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2012-01-19 09:01 PST, Jer Noble 		sullivan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-01-16 09:52:04 PST 
Crash at WebCore::MediaControlRootElement::makeOpaque + 97
Comment 1 Jer Noble 2012-01-16 09:52:39 PST 
<rdar://problem/9670476>
Comment 2 Jer Noble 2012-01-16 09:57:04 PST 
Created attachment 122659 [details]
Patch
Comment 3 Daniel Bates 2012-01-17 09:32:22 PST 
Comment on attachment 122659 [details]
Patch

This patch needs to be rebased as it no longer applies cleanly because the function MediaControlRootElement::makeOpaque() has changed significantly.  In particular, the line this patch changes no longer exists as it was removed in <http://trac.webkit.org/changeset/97157> (bug #58157). This changeset also moved the implementation of MediaControlRootElement::makeOpaque() into MediaControlPanelElement::makeOpaque() in file /Source/WebCore/html/shadow/MediaControlElements.cpp: <http://trac.webkit.org/browser/trunk/Source/WebCore/html/shadow/MediaControlElements.cpp?rev=105163#L207>.
Comment 4 Jer Noble 2012-01-19 09:01:22 PST 
Created attachment 123139 [details]
Patch

Rebased against new location of makeOpaque() code.
Comment 5 John Sullivan 2012-01-19 10:16:29 PST 
Comment on attachment 123139 [details]
Patch

Is the case where document()->page() is nil ever expected? If not, maybe it’s worth adding an assertion?
Comment 6 Jer Noble 2012-01-19 10:23:06 PST 
(In reply to comment #5)
> (From update of attachment 123139 [details])
> Is the case where document()->page() is nil ever expected? If not, maybe it’s worth adding an assertion?

In the Document.h header, it states that page() "can be NULL", so I assumed it was expected.

Thanks!
Comment 7 Jer Noble 2012-01-19 10:53:54 PST 
Committed r105425: <http://trac.webkit.org/changeset/105425>