WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76382
Web Inspector: CodeGeneratorInspector.py: start using typedefs
https://bugs.webkit.org/show_bug.cgi?id=76382
Summary
Web Inspector: CodeGeneratorInspector.py: start using typedefs
Peter Rybin
Reported
2012-01-16 07:16:01 PST
Currently we generated typedefs for named string types, but not use them. Start using them.
Attachments
Patch
(10.73 KB, patch)
2012-01-16 07:22 PST
,
Peter Rybin
no flags
Details
Formatted Diff
Diff
InspectorFrontend.h base version
(156.38 KB, text/plain)
2012-01-16 07:32 PST
,
Peter Rybin
no flags
Details
New InspectorFrontend.h
(157.72 KB, text/plain)
2012-01-16 07:33 PST
,
Peter Rybin
no flags
Details
Generator output diff
(8.84 KB, text/plain)
2012-01-16 07:33 PST
,
Peter Rybin
no flags
Details
Patch
(10.77 KB, patch)
2012-01-16 12:03 PST
,
Peter Rybin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Peter Rybin
Comment 1
2012-01-16 07:22:03 PST
Created
attachment 122632
[details]
Patch
Peter Rybin
Comment 2
2012-01-16 07:32:13 PST
Created
attachment 122633
[details]
InspectorFrontend.h base version
Peter Rybin
Comment 3
2012-01-16 07:33:02 PST
Created
attachment 122634
[details]
New InspectorFrontend.h
Peter Rybin
Comment 4
2012-01-16 07:33:55 PST
Created
attachment 122635
[details]
Generator output diff
Yury Semikhatsky
Comment 5
2012-01-16 07:47:07 PST
Comment on
attachment 122632
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=122632&action=review
> Source/WebCore/inspector/CodeGeneratorInspector.py:661 > return
return None?
Peter Rybin
Comment 6
2012-01-16 12:03:18 PST
Created
attachment 122670
[details]
Patch
WebKit Review Bot
Comment 7
2012-01-17 07:46:02 PST
Comment on
attachment 122670
[details]
Patch Clearing flags on attachment: 122670 Committed
r105160
: <
http://trac.webkit.org/changeset/105160
>
WebKit Review Bot
Comment 8
2012-01-17 07:46:08 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug