Bug 76382 - Web Inspector: CodeGeneratorInspector.py: start using typedefs
Summary: Web Inspector: CodeGeneratorInspector.py: start using typedefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 72861
  Show dependency treegraph
 
Reported: 2012-01-16 07:16 PST by Peter Rybin
Modified: 2012-01-17 07:46 PST (History)
12 users (show)

See Also:


Attachments
Patch (10.73 KB, patch)
2012-01-16 07:22 PST, Peter Rybin
no flags Details | Formatted Diff | Diff
InspectorFrontend.h base version (156.38 KB, text/plain)
2012-01-16 07:32 PST, Peter Rybin
no flags Details
New InspectorFrontend.h (157.72 KB, text/plain)
2012-01-16 07:33 PST, Peter Rybin
no flags Details
Generator output diff (8.84 KB, text/plain)
2012-01-16 07:33 PST, Peter Rybin
no flags Details
Patch (10.77 KB, patch)
2012-01-16 12:03 PST, Peter Rybin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-01-16 07:16:01 PST
Currently we generated typedefs for named string types, but not use them. Start using them.
Comment 1 Peter Rybin 2012-01-16 07:22:03 PST
Created attachment 122632 [details]
Patch
Comment 2 Peter Rybin 2012-01-16 07:32:13 PST
Created attachment 122633 [details]
InspectorFrontend.h base version
Comment 3 Peter Rybin 2012-01-16 07:33:02 PST
Created attachment 122634 [details]
New InspectorFrontend.h
Comment 4 Peter Rybin 2012-01-16 07:33:55 PST
Created attachment 122635 [details]
Generator output diff
Comment 5 Yury Semikhatsky 2012-01-16 07:47:07 PST
Comment on attachment 122632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122632&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:661
>                              return

return None?
Comment 6 Peter Rybin 2012-01-16 12:03:18 PST
Created attachment 122670 [details]
Patch
Comment 7 WebKit Review Bot 2012-01-17 07:46:02 PST
Comment on attachment 122670 [details]
Patch

Clearing flags on attachment: 122670

Committed r105160: <http://trac.webkit.org/changeset/105160>
Comment 8 WebKit Review Bot 2012-01-17 07:46:08 PST
All reviewed patches have been landed.  Closing bug.