Bug 76364 - Add tests for dynamic attribute changes and svg for mapping of lang/xml:lang to -webkit-locale
Summary: Add tests for dynamic attribute changes and svg for mapping of lang/xml:lang ...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 53783 80658
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-15 21:58 PST by Matt Falkenhagen
Modified: 2017-07-18 17:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.70 KB, patch)
2012-01-18 18:20 PST, Matt Falkenhagen
no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2012-02-06 22:06 PST, Matt Falkenhagen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Falkenhagen 2012-01-15 21:58:34 PST
Spin off of Alexey's comment on bug 67586: https://bugs.webkit.org/show_bug.cgi?id=67586#c34
Comment 1 Matt Falkenhagen 2012-01-18 18:20:31 PST
Created attachment 123049 [details]
Patch
Comment 2 Matt Falkenhagen 2012-02-06 22:06:19 PST
Created attachment 125768 [details]
Patch
Comment 3 Hajime Morrita 2012-02-20 21:04:21 PST
Comment on attachment 125768 [details]
Patch

Basically looks good. Maybe we could have test with removeAttribute().
Comment 4 Matt Falkenhagen 2012-03-08 17:37:35 PST
Comment on attachment 125768 [details]
Patch

Thanks for the review. I've put a revised patch at bug 80658 since it doesn't deal with SVG at all.
Comment 5 Hajime Morrita 2012-03-08 17:59:41 PST
(In reply to comment #4)
> (From update of attachment 125768 [details])
> Thanks for the review. I've put a revised patch at bug 80658 since it doesn't deal with SVG at all.
So is it OK to close this?
Comment 6 Matt Falkenhagen 2012-03-08 18:39:07 PST
I was planning to keep this bug open as it includes adding tests for SVG, which hasn't been worked on yet, and treat bug 80658 as a subtask of it.
Comment 7 Simon Fraser (smfr) 2013-03-18 18:02:08 PDT
fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml is often flakey:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r146151%20(6480)/fast/css/lang-mapped-to-webkit-locale-dynamic-pretty-diff.html
Comment 8 Matt Falkenhagen 2017-07-18 17:16:23 PDT
I believe the remaining task here is adding tests for mapping of lang/xml:lang to -webkit-locale when lang/xml:lang was set in SVG.