Bug 76344 - [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
Summary: [WK2] Navigation events not triggered by a mouse event claim to be triggered ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 76343
  Show dependency tree / graph
 
Reported: 2012-01-15 09:16 PST by Martin Robinson
Modified: 2012-01-25 12:39 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2012-01-15 10:33 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch adding test (4.60 KB, patch)
2012-01-21 12:06 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-01-15 09:16:36 PST 
During policy decision, navigation events that were not triggered by the mouse should claim that they were triggered by WebMouseEvent::NoButton intsead of WebMouseEvent::LeftButton.
Comment 1 Martin Robinson 2012-01-15 10:33:58 PST 
Created attachment 122569 [details]
Patch
Comment 2 Sam Weinig 2012-01-20 16:21:42 PST 
Comment on attachment 122569 [details]
Patch

If you can, it would be great to add a test case to TestWebKitAPI, but it is not absolutely necessary for this simple a fix.
Comment 3 Martin Robinson 2012-01-21 12:06:17 PST 
Created attachment 123454 [details]
Patch adding test
Comment 4 Martin Robinson 2012-01-21 12:09:22 PST 
Added a patch with a test. GTK+ doesn't yet build the C API tests yet, so I'm doing this blindly. If it passes the EWS I'll land it and watch the bots. Thanks for the review!
Comment 5 Martin Robinson 2012-01-25 12:37:19 PST 
Committed r105916: <http://trac.webkit.org/changeset/105916>