Bug 76330 – [Qt] css3/flexbox/flex-align.html fails with 1px off error

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit Qt

[Ojan Vafai]

Seems likely a rounding difference, but I'm not really sure what about the test is platform specific or would be affected by rounding of any kind. Here's an example error from the test:

FAIL:
Expected 100 for offsetTop, but got 101. 
Expected 100 for height, but got 101. 

<div class="flexbox" style="-webkit-flex-align: start">
    <div data-expected-height="100" data-offset-y="0" style="-webkit-flex-item-align: auto; width: -webkit-flex(1 0 0); height: 100px;"></div>
    <div data-expected-height="0" data-offset-y="0" style="-webkit-flex-item-align: auto; width: -webkit-flex(1 0 0);"></div>
    <div data-expected-height="0" data-offset-y="0" style="-webkit-flex-item-align: start; width: -webkit-flex(1 0 0);"></div>
    <div data-expected-height="0" data-offset-y="100" style="-webkit-flex-item-align: end; width: -webkit-flex(1 0 0);"></div>
    <div data-expected-height="0" data-offset-y="50" style="-webkit-flex-item-align: center; width: -webkit-flex(1 0 0);"></div>
    <div data-offset-y="20" style="-webkit-flex-item-align: baseline; width: -webkit-flex(1 0 0);"><div style="display:inline-block;"></div></div>
    <div data-offset-y="20" style="-webkit-flex-item-align: baseline; width: -webkit-flex(1 0 0); margin: 20px;"><div style="display:inline-block;"></div></div>
    <div data-expected-height="100" data-offset-y="0" style="-webkit-flex-item-align: stretch; width: -webkit-flex(1 0 0);"></div>
</div>

I'm going to skip the test for now unless someone from QT would like me to do otherwise.

[Ojan Vafai]

To clarify, http://trac.webkit.org/changeset/105015 added new cases to this test that started failing. The failures are not new from the C++ code in http://trac.webkit.org/changeset/105015 though.

Skipped in http://trac.webkit.org/changeset/105016.

[Caio Marcelo de Oliveira Filho]

Tested this with Qt 4.8.1 + WebKit trunk, and with Qt 5.0 (51ca55ff29f53b909c3614b56609e067d2066124) + WebKit trunk for both WK1 and WK2. In all three scenarios, the test is passing.

My environment is similar to the Qt Build bot (Ubuntu Linux). Ossy, could you double check this on the bot for us?

[Csaba Osztrogonác]

It works for me on 32/64 bit with Qt4/5 too, so unskip landed in r117765.