Bug 76326 - getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
Summary: getComputedStyle of flex-item-align:auto should resolve to it's parent's flex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2012-01-13 18:48 PST by Ojan Vafai
Modified: 2012-02-15 12:26 PST (History)
1 user (show)

See Also:

Attachments
Patch (10.46 KB, patch)
2012-02-15 11:54 PST, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-13 18:48:00 PST 
Summary: getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
Comment 1 Ojan Vafai 2012-02-15 11:54:19 PST 
Created attachment 127209 [details]
Patch
Comment 2 Tony Chang 2012-02-15 12:05:29 PST 
Comment on attachment 127209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127209&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1587
> +            if (m_node && m_node->parentNode() && m_node->parentNode()->computedStyle() && style->flexItemAlign() == AlignAuto)

I would put the style->flexItemAlign() == AlignAuto check first so we don't do all the other checks for other alignments.
Comment 3 Ojan Vafai 2012-02-15 12:26:59 PST 
Committed r107833: <http://trac.webkit.org/changeset/107833>