Bug 76314 - HWndDC should be in platform/win instead of wtf.
Summary: HWndDC should be in platform/win instead of wtf.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 15:10 PST by David Levin
Modified: 2012-01-14 19:14 PST (History)
1 user (show)

See Also:


Attachments
Patch (10.05 KB, patch)
2012-01-13 15:25 PST, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2012-01-13 15:10:16 PST
Per https://bugs.webkit.org/show_bug.cgi?id=76235#c12
Comment 1 David Levin 2012-01-13 15:25:05 PST
Created attachment 122508 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-13 15:27:36 PST
Attachment 122508 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/platform/win/HWndDC.h:39:  Use the class HWndDC instead of calling GetDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
Source/WebCore/platform/win/HWndDC.h:45:  Use the class HWndDC instead of calling GetDCEx to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Levin 2012-01-13 15:29:45 PST
(In reply to comment #2)
> Attachment 122508 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> 
> Source/WebCore/platform/win/HWndDC.h:39:  Use the class HWndDC instead of calling GetDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
> Source/WebCore/platform/win/HWndDC.h:45:  Use the class HWndDC instead of calling GetDCEx to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
> Total errors found: 2 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Expected for this particular file.
Comment 4 WebKit Review Bot 2012-01-14 19:14:24 PST
Comment on attachment 122508 [details]
Patch

Clearing flags on attachment: 122508

Committed r105028: <http://trac.webkit.org/changeset/105028>
Comment 5 WebKit Review Bot 2012-01-14 19:14:28 PST
All reviewed patches have been landed.  Closing bug.