WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76313
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
https://bugs.webkit.org/show_bug.cgi?id=76313
Summary
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
WebKit Review Bot
Reported
2012-01-13 14:43:41 PST
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red Requested by jamesr on #webkit.
Attachments
Patch
(1.32 KB, patch)
2012-01-13 17:22 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.31 KB, patch)
2012-01-14 10:12 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-01-13 14:44:21 PST
See
https://bugs.webkit.org/show_bug.cgi?id=76274
. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green.
Adrienne Walker
Comment 2
2012-01-13 15:10:46 PST
(In reply to
comment #1
)
> See
https://bugs.webkit.org/show_bug.cgi?id=76274
. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green.
abarth says that this is what's checking for unit test failures. 15:01 < abarth> self._tool.executive.run_and_throw_if_fail(webkit_unit_tests_command, cwd=self._tool.scm().checkout_root) In local testing, webkit_unit_tests returned an exit code of 1 on failure and 0 on success.
Adam Barth
Comment 3
2012-01-13 15:32:08 PST
Maybe the perl wrapper eats the return code?
Adam Barth
Comment 4
2012-01-13 15:33:00 PST
The way I would test this is by locally introducing an error in the unit tests and seeing if that line throws.
James Robinson
Comment 5
2012-01-13 17:20:19 PST
We appear to lose the exit code going through the perl wrapper script run-chromium-webkit-unit-tests
James Robinson
Comment 6
2012-01-13 17:22:36 PST
Created
attachment 122521
[details]
Patch
James Robinson
Comment 7
2012-01-13 17:23:02 PST
This is what
http://perldoc.perl.org/functions/system.html
says you are supposed to do, and it seems to work.
Adam Barth
Comment 8
2012-01-13 17:36:57 PST
Comment on
attachment 122521
[details]
Patch Ok. I surrender.
James Robinson
Comment 9
2012-01-14 10:12:28 PST
Created
attachment 122550
[details]
Patch for landing
WebKit Review Bot
Comment 10
2012-01-14 11:28:57 PST
Comment on
attachment 122550
[details]
Patch for landing Clearing flags on attachment: 122550 Committed
r105022
: <
http://trac.webkit.org/changeset/105022
>
WebKit Review Bot
Comment 11
2012-01-14 11:29:01 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug