Bug 76313 - [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
Summary: [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 14:43 PST by WebKit Review Bot
Modified: 2012-01-14 11:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2012-01-13 17:22 PST, James Robinson
no flags Details | Formatted Diff | Diff
Patch for landing (1.31 KB, patch)
2012-01-14 10:12 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-01-13 14:43:41 PST
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
Requested by jamesr on #webkit.
Comment 1 James Robinson 2012-01-13 14:44:21 PST
See https://bugs.webkit.org/show_bug.cgi?id=76274. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green.
Comment 2 Adrienne Walker 2012-01-13 15:10:46 PST
(In reply to comment #1)
> See https://bugs.webkit.org/show_bug.cgi?id=76274. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green.

abarth says that this is what's checking for unit test failures.

15:01 < abarth>             
self._tool.executive.run_and_throw_if_fail(webkit_unit_tests_command, 
                cwd=self._tool.scm().checkout_root)

In local testing, webkit_unit_tests returned an exit code of 1 on failure and 0 on success.
Comment 3 Adam Barth 2012-01-13 15:32:08 PST
Maybe the perl wrapper eats the return code?
Comment 4 Adam Barth 2012-01-13 15:33:00 PST
The way I would test this is by locally introducing an error in the unit tests and seeing if that line throws.
Comment 5 James Robinson 2012-01-13 17:20:19 PST
We appear to lose the exit code going through the perl wrapper script run-chromium-webkit-unit-tests
Comment 6 James Robinson 2012-01-13 17:22:36 PST
Created attachment 122521 [details]
Patch
Comment 7 James Robinson 2012-01-13 17:23:02 PST
This is what http://perldoc.perl.org/functions/system.html says you are supposed to do, and it seems to work.
Comment 8 Adam Barth 2012-01-13 17:36:57 PST
Comment on attachment 122521 [details]
Patch

Ok.  I surrender.
Comment 9 James Robinson 2012-01-14 10:12:28 PST
Created attachment 122550 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-01-14 11:28:57 PST
Comment on attachment 122550 [details]
Patch for landing

Clearing flags on attachment: 122550

Committed r105022: <http://trac.webkit.org/changeset/105022>
Comment 11 WebKit Review Bot 2012-01-14 11:29:01 PST
All reviewed patches have been landed.  Closing bug.