[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red Requested by jamesr on #webkit.
See https://bugs.webkit.org/show_bug.cgi?id=76274. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green.
(In reply to comment #1) > See https://bugs.webkit.org/show_bug.cgi?id=76274. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green. abarth says that this is what's checking for unit test failures. 15:01 < abarth> self._tool.executive.run_and_throw_if_fail(webkit_unit_tests_command, cwd=self._tool.scm().checkout_root) In local testing, webkit_unit_tests returned an exit code of 1 on failure and 0 on success.
Maybe the perl wrapper eats the return code?
The way I would test this is by locally introducing an error in the unit tests and seeing if that line throws.
We appear to lose the exit code going through the perl wrapper script run-chromium-webkit-unit-tests
Created attachment 122521 [details] Patch
This is what http://perldoc.perl.org/functions/system.html says you are supposed to do, and it seems to work.
Comment on attachment 122521 [details] Patch Ok. I surrender.
Created attachment 122550 [details] Patch for landing
Comment on attachment 122550 [details] Patch for landing Clearing flags on attachment: 122550 Committed r105022: <http://trac.webkit.org/changeset/105022>
All reviewed patches have been landed. Closing bug.