Bug 76310 - Remove StackBounds from JSGlobalData
Summary: Remove StackBounds from JSGlobalData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 14:11 PST by Mark Hahnenberg
Modified: 2012-01-23 13:36 PST (History)
0 users

See Also:

Attachments
Patch (2.63 KB, patch)
2012-01-20 15:43 PST, Mark Hahnenberg 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-01-13 14:11:03 PST 
It appears that the distinction between a Default GlobalDataType for JSGlobalData and others serves no visible purpose when determining which StackBounds object to return--we should always return the StackBounds of the current thread (i.e. wtfThreadData().stack()). If this is indeed the case, we should remove this distinction to simplify the code base.
Comment 1 Mark Hahnenberg 2012-01-20 15:43:06 PST 
Created attachment 123398 [details]
Patch
Comment 2 Sam Weinig 2012-01-22 14:09:46 PST 
Comment on attachment 123398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123398&action=review

> Source/JavaScriptCore/runtime/JSGlobalData.h:229
>          const StackBounds& stack()
>          {
> -            return (globalDataType == Default)
> -                ? m_stack
> -                : wtfThreadData().stack();
> +            return wtfThreadData().stack();
>          }

It seems odd to keep this interface, if it no longer access JSGlobalData members.
Comment 3 Mark Hahnenberg 2012-01-23 13:36:33 PST 
Committed r105638: <http://trac.webkit.org/changeset/105638>