RESOLVED FIXED 76310
Remove StackBounds from JSGlobalData 
https://bugs.webkit.org/show_bug.cgi?id=76310
Summary Remove StackBounds from JSGlobalData
Mark Hahnenberg
Reported 2012-01-13 14:11:03 PST
It appears that the distinction between a Default GlobalDataType for JSGlobalData and others serves no visible purpose when determining which StackBounds object to return--we should always return the StackBounds of the current thread (i.e. wtfThreadData().stack()). If this is indeed the case, we should remove this distinction to simplify the code base.
Attachments
Patch (2.63 KB, patch)
2012-01-20 15:43 PST, Mark Hahnenberg 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-01-20 15:43:06 PST
Created attachment 123398 [details] Patch
Sam Weinig
Comment 2 2012-01-22 14:09:46 PST
Comment on attachment 123398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123398&action=review > Source/JavaScriptCore/runtime/JSGlobalData.h:229 > const StackBounds& stack() > { > - return (globalDataType == Default) > - ? m_stack > - : wtfThreadData().stack(); > + return wtfThreadData().stack(); > } It seems odd to keep this interface, if it no longer access JSGlobalData members.
Mark Hahnenberg
Comment 3 2012-01-23 13:36:33 PST
Committed r105638: <http://trac.webkit.org/changeset/105638>
Note You need to log in before you can comment on or make changes to this bug.