NEW 76305
Templatizing CSSValuePool::createIdentifierValue() would simplify CSSComputedStyleDeclaration::getPropertyCSSValue() 
https://bugs.webkit.org/show_bug.cgi?id=76305
Summary Templatizing CSSValuePool::createIdentifierValue() would simplify CSSComputed...
Jon Lee
Reported 2012-01-13 13:38:27 PST
In the case of CSSPropertyTextOverflow we see this code: case CSSPropertyTextOverflow: if (style->textOverflow()) return cssValuePool->createIdentifierValue(CSSValueEllipsis); return cssValuePool->createIdentifierValue(CSSValueClip); Templatizing createIdentifierValue() would allow us to reduce this to just one line, leverage the mappings implemented in CSSPrimitiveValueMappings.h. (See https://bugs.webkit.org/show_bug.cgi?id=76118#c8)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-01-13 13:38:47 PST
<rdar://problem/10692989>
Note You need to log in before you can comment on or make changes to this bug.