Bug 76297 - Partially revert r104756 - multipart bugs
Summary: Partially revert r104756 - multipart bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 12:22 PST by Nate Chapin
Modified: 2012-01-13 15:33 PST (History)
4 users (show)

See Also:


Attachments
patch (4.60 KB, patch)
2012-01-13 12:54 PST, Nate Chapin
no flags Details | Formatted Diff | Diff
Patch for landing (5.63 KB, patch)
2012-01-13 14:51 PST, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2012-01-13 12:22:14 PST
The multipart code in SubresourceLoader has some subtleties I misunderstood when I tried to change them in http://trac.webkit.org/changeset/104756. That patch is causing a multipart test to assert in chromium win, and I suspect there are other issues I haven't found yet.

I'm going to revert all the multipart changes (except the changes to CachedImage and when we call clear()) and give them more thought before trying again.
Comment 1 Nate Chapin 2012-01-13 12:54:45 PST
Created attachment 122485 [details]
patch
Comment 2 Alexey Proskuryakov 2012-01-13 12:55:38 PST
Comment on attachment 122485 [details]
patch

rs=me
Comment 3 Early Warning System Bot 2012-01-13 13:04:40 PST
Comment on attachment 122485 [details]
patch

Attachment 122485 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11152701
Comment 4 Nate Chapin 2012-01-13 14:51:18 PST
Created attachment 122505 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-13 15:33:00 PST
Comment on attachment 122505 [details]
Patch for landing

Clearing flags on attachment: 122505

Committed r105000: <http://trac.webkit.org/changeset/105000>
Comment 6 WebKit Review Bot 2012-01-13 15:33:05 PST
All reviewed patches have been landed.  Closing bug.