Bug 76292 - [EFL] Emit "resource,request,willsend" from ewk_view.
Summary: [EFL] Emit "resource,request,willsend" from ewk_view.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 11:16 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2012-01-17 07:03 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2012-01-13 11:16 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Take Ryuan's comment into account (2.86 KB, patch)
2012-01-16 20:16 PST, Raphael Kubo da Costa (:rakuco)
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-01-13 11:16:18 PST
[EFL] Emit "resource,request,willsend" from ewk_view.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-01-13 11:16:54 PST
Created attachment 122469 [details]
Patch
Comment 2 Leandro Pereira 2012-01-16 14:19:13 PST
LGTM.
Comment 3 Ryuan Choi 2012-01-16 17:59:42 PST
Comment on attachment 122469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122469&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:178
> +    const FrameLoader* frameLoader = loader->frameLoader();
> +    const bool isMainFrameRequest = (loader && loader == frameLoader->provisionalDocumentLoader() && frameLoader->isLoadingMainFrame());

If loader can be null, 177 line make crash.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-01-16 20:16:38 PST
Created attachment 122706 [details]
Take Ryuan's comment into account
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-01-17 07:03:05 PST
Committed r105152: <http://trac.webkit.org/changeset/105152>