WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76292
[EFL] Emit "resource,request,willsend" from ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=76292
Summary
[EFL] Emit "resource,request,willsend" from ewk_view.
Raphael Kubo da Costa (:rakuco)
Reported
2012-01-13 11:16:18 PST
[EFL] Emit "resource,request,willsend" from ewk_view.
Attachments
Patch
(2.83 KB, patch)
2012-01-13 11:16 PST
,
Raphael Kubo da Costa (:rakuco)
no flags
Details
Formatted Diff
Diff
Take Ryuan's comment into account
(2.86 KB, patch)
2012-01-16 20:16 PST
,
Raphael Kubo da Costa (:rakuco)
kling
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1
2012-01-13 11:16:54 PST
Created
attachment 122469
[details]
Patch
Leandro Pereira
Comment 2
2012-01-16 14:19:13 PST
LGTM.
Ryuan Choi
Comment 3
2012-01-16 17:59:42 PST
Comment on
attachment 122469
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=122469&action=review
> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:178 > + const FrameLoader* frameLoader = loader->frameLoader(); > + const bool isMainFrameRequest = (loader && loader == frameLoader->provisionalDocumentLoader() && frameLoader->isLoadingMainFrame());
If loader can be null, 177 line make crash.
Raphael Kubo da Costa (:rakuco)
Comment 4
2012-01-16 20:16:38 PST
Created
attachment 122706
[details]
Take Ryuan's comment into account
Raphael Kubo da Costa (:rakuco)
Comment 5
2012-01-17 07:03:05 PST
Committed
r105152
: <
http://trac.webkit.org/changeset/105152
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug