Bug 76286 - Eval in strict mode does not need dynamic checks
Summary: Eval in strict mode does not need dynamic checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Wingo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 10:39 PST by Andy Wingo
Modified: 2012-01-13 12:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2012-01-13 10:40 PST, Andy Wingo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wingo 2012-01-13 10:39:02 PST 
The patch to be attached says:

        * runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):
        Eval in strict mode cannot introduce variables, so it not impose
        the need for dynamic checks.
Comment 1 Andy Wingo 2012-01-13 10:40:11 PST 
Created attachment 122451 [details]
Patch
Comment 2 Geoffrey Garen 2012-01-13 11:01:16 PST 
This looks right to me. Oliver, what do you think?
Comment 3 Oliver Hunt 2012-01-13 11:36:42 PST 
Comment on attachment 122451 [details]
Patch

Oh, i never thought about doing it that way.  Hilariously simple.  r=me.
Comment 4 WebKit Review Bot 2012-01-13 12:31:57 PST 
Comment on attachment 122451 [details]
Patch

Clearing flags on attachment: 122451

Committed r104970: <http://trac.webkit.org/changeset/104970>
Comment 5 WebKit Review Bot 2012-01-13 12:32:01 PST 
All reviewed patches have been landed.  Closing bug.