Bug 76284 – [GTK] Include gtk+3 in the jhbuild modules

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mario Sanchez Prada]

We need to add gtk+3 to the jhbuild modules to avoid breaking things if building with a too recent version of GTK+ (greater than 3.3.4), which would fail to find symbols like g_menu_*(), not present in glib 2.31.2 (the version currently included in WKGTK's jhbuild modules).

We could raise glib up to 2.31.4, but this would cause even more trouble when trying to build libsoup (it will fail to link due to not finding g_module_open() while generating the introspection information) and so it seems more sensible to add gtk+3, instead.

[Mario Sanchez Prada]

Created attachment 122447 [details]
Patch proposal

Reviewer: If you give r+ to this patch, feel free to set cq+ if you want, otherwise I'll push it next week.

[WebKit Review Bot]

Comment on attachment 122447 [details]
Patch proposal

Clearing flags on attachment: 122447

Committed r105017: <http://trac.webkit.org/changeset/105017>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

configure: error: Package requirements (glib-2.0 >= 2.31.0    atk >= 2.1.5    pango >= 1.29.0    cairo >= 1.10.0    cairo-gobject >= 1.10.0    gdk-pixbuf-2.0 >= 2.23.5) were not met:

Requested 'atk >= 2.1.5' but version of Atk is 2.0.1
Requested 'pango >= 1.29.0' but version of Pango is 1.28.4

Rolling out.

[Philippe Normand]

^^

[Martin Robinson]

(In reply to comment #5)
> ^^

Sorry Mario. I probably should have been a little clearer when explaining this before. It's important to figure out what version of GTK+ the bots are using and start with that in the jhbuild modules.

[Mario Sanchez Prada]

(In reply to comment #6)
> (In reply to comment #5)
> > ^^
> 
> Sorry Mario. I probably should have been a little clearer when explaining this before. It's important to figure out what version of GTK+ the bots are using and start with that in the jhbuild modules.

No problem. I'm now trying a full build with a new version of this patch (using gtk+ 3.0.12, as in the 64 bit debug bot) and, if it works, I'll be uploading it pretty soon.

Thanks!

[Mario Sanchez Prada]

Created attachment 122609 [details]
Patch proposal

Attaching new patch including GTK+ 3.0.12 (version currently present in the GTK 64bit debug bot) in the moduleset. Also, added as dependency for "gnome-icon-theme", as per the deps-graph in GNOME's modulesets.

Last, I added the '-lm' flag manually in jhbuildrc, since for some reason the tarball for GTK 3.0.12 was not "smart enough" for adding it when linking the tests,so it would fail (at least for me) due to not being able to find floor() function :/. If there's a better way to workaround this issue, I'm all ears.

[Philippe Normand]

Comment on attachment 122609 [details]
Patch proposal

Ok let's try this one :)

[WebKit Review Bot]

Comment on attachment 122609 [details]
Patch proposal

Clearing flags on attachment: 122609

Committed r105075: <http://trac.webkit.org/changeset/105075>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.