Bug 76276 - [Qt] [WK2] Get rid of the dependency to QtWidgets
Summary: [Qt] [WK2] Get rid of the dependency to QtWidgets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on: 76275
Blocks: 78109
  Show dependency tree / graph
 
Reported: 2012-01-13 07:54 PST by Andras Becsi
Modified: 2012-02-21 02:58 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (12.37 KB, patch)
2012-02-20 08:50 PST, Andras Becsi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2012-01-13 07:54:27 PST 
QScroller is going away from Qt5 (and QtWebKit) soon thus we should drop its widgets dependency as well.
Comment 1 Andras Becsi 2012-02-20 08:50:19 PST 
Created attachment 127822 [details]
proposed patch

This patch probably needs a clean build for the bot.
Comment 2 Simon Hausmann 2012-02-20 12:54:07 PST 
Comment on attachment 127822 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127822&action=review

LGTM, but I think the code in ActivateFontsQt.cpp should be re-added before landing.

> Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:-48
> -#endif

Don't we still need these for the layout tests for the time being? It's okay to use Widget stuff in WTR / the bundle, since this code isn't in the library itself.
Comment 3 Andras Becsi 2012-02-21 02:57:38 PST 
Committed r108328: <http://trac.webkit.org/changeset/108328>
Comment 4 Andras Becsi 2012-02-21 02:58:23 PST 
Comment on attachment 127822 [details]
proposed patch

Clearing flags from attachment.