Bug 76271 - JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
Summary: JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2012-01-13 06:19 PST by Andreas Kling
Modified: 2012-01-13 08:41 PST (History)
2 users (show)

See Also:

Patch (1.81 KB, patch)
2012-01-13 06:21 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-01-13 06:19:19 PST
JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
Comment 1 Andreas Kling 2012-01-13 06:21:17 PST
Created attachment 122422 [details]
Comment 2 Andreas Kling 2012-01-13 08:35:40 PST
Comment on attachment 122422 [details]

Clearing flags on attachment: 122422

Committed r104941: <http://trac.webkit.org/changeset/104941>
Comment 3 Andreas Kling 2012-01-13 08:35:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2012-01-13 08:41:42 PST
By the way, another way to do this that might be less roundabout would be to add a function that does assignment for JSC::Weak. Something named “set” or “assign”. We’d use that instead of “construct and swap”.

I have a possibly-unfounded suspicion move semantics in C++11 also would have helped do this in a more elegant way, but we can’t rely on that at this time.