Bug 76269 - [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
Summary: [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 05:54 PST by Gabor Rapcsanyi
Modified: 2012-01-13 09:04 PST (History)
6 users (show)

See Also:


Attachments
proposed patch (1.15 KB, patch)
2012-01-13 05:59 PST, Gabor Rapcsanyi
gns: commit-queue-
Details | Formatted Diff | Diff
proposed patch v2 (1.22 KB, patch)
2012-01-13 06:51 PST, Gabor Rapcsanyi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2012-01-13 05:54:10 PST
gtkdoc.py drop the LDFLAGS and CFLAGS environment variables when it runs gtkdoc_scangobj. It would be good if it just add the new flags instead of remove what was set. This would make easier the cross compilation of GTK WebKit.
Comment 1 Gabor Rapcsanyi 2012-01-13 05:59:50 PST
Created attachment 122418 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2012-01-13 06:06:42 PST
Comment on attachment 122418 [details]
proposed patch

Attachment 122418 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11157579
Comment 3 Gabor Rapcsanyi 2012-01-13 06:51:05 PST
Created attachment 122425 [details]
proposed patch v2
Comment 4 Martin Robinson 2012-01-13 08:10:08 PST
Comment on attachment 122425 [details]
proposed patch v2

Thanks for the fix!
Comment 5 WebKit Review Bot 2012-01-13 09:04:47 PST
Comment on attachment 122425 [details]
proposed patch v2

Clearing flags on attachment: 122425

Committed r104942: <http://trac.webkit.org/changeset/104942>
Comment 6 WebKit Review Bot 2012-01-13 09:04:51 PST
All reviewed patches have been landed.  Closing bug.