RESOLVED FIXED 76269
[GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables 
https://bugs.webkit.org/show_bug.cgi?id=76269
Summary [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
Gabor Rapcsanyi
Reported 2012-01-13 05:54:10 PST
gtkdoc.py drop the LDFLAGS and CFLAGS environment variables when it runs gtkdoc_scangobj. It would be good if it just add the new flags instead of remove what was set. This would make easier the cross compilation of GTK WebKit.
Attachments
proposed patch (1.15 KB, patch)
2012-01-13 05:59 PST, Gabor Rapcsanyi 		gustavo: commit-queue-
DetailsFormatted DiffDiff
proposed patch v2 (1.22 KB, patch)
2012-01-13 06:51 PST, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2012-01-13 05:59:50 PST
Created attachment 122418 [details] proposed patch
Gustavo Noronha (kov)
Comment 2 2012-01-13 06:06:42 PST
Comment on attachment 122418 [details] proposed patch Attachment 122418 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11157579
Gabor Rapcsanyi
Comment 3 2012-01-13 06:51:05 PST
Created attachment 122425 [details] proposed patch v2
Martin Robinson
Comment 4 2012-01-13 08:10:08 PST
Comment on attachment 122425 [details] proposed patch v2 Thanks for the fix!
WebKit Review Bot
Comment 5 2012-01-13 09:04:47 PST
Comment on attachment 122425 [details] proposed patch v2 Clearing flags on attachment: 122425 Committed r104942: <http://trac.webkit.org/changeset/104942>
WebKit Review Bot
Comment 6 2012-01-13 09:04:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.