Bug 76264 - Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
Summary: Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on: 76277
Blocks: 75386
  Show dependency treegraph
 
Reported: 2012-01-13 03:44 PST by Vsevolod Vlasov
Modified: 2012-01-23 12:49 PST (History)
12 users (show)

See Also:


Attachments
Patch (36.98 KB, patch)
2012-01-13 04:08 PST, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-01-13 03:44:05 PST
Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.

This patch contains
 - new InspectorIndexedDBAgent backend boilerplate
 - new IndexedDBModel front-end boilerplate
 - proposed implementation of getDatabaseNames for all frames.
Comment 1 Vsevolod Vlasov 2012-01-13 04:08:36 PST
Created attachment 122407 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-01-13 04:08:55 PST
This implementation is ready to review.
Known issues:
 - xcode project is not yet updated.
 - There are no tests, I am going to add tests separately, once I implement ResourcePanel - IndexedDBModel interaction.
Comment 3 Pavel Feldman 2012-01-13 05:25:00 PST
Comment on attachment 122407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122407&action=review

> Source/WebCore/inspector/Inspector.json:111
> +                    { "name": "securityOrigin", "type": "string", "description": "Frame document's security origin." },

Should we make this field optional?

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:110
> +        RefPtr<InspectorObject> result = InspectorObject::create();

You should use new generated API for front-end messages.

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:166
> +    m_enabled = true;

I don't introduce these unless performance matters.

> Source/WebCore/inspector/InspectorIndexedDBAgent.h:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/front-end/IndexedDBModel.js:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/front-end/IndexedDBModel.js:203
> +    

Extra blank line.
Comment 4 Vsevolod Vlasov 2012-01-13 07:08:48 PST
Committed r104935: <http://trac.webkit.org/changeset/104935>
Comment 5 Vsevolod Vlasov 2012-01-13 08:28:30 PST
Committed r104940: <http://trac.webkit.org/changeset/104940>