Bug 76252 - Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large heap snapshot.
Summary: Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2012-01-13 00:23 PST by Ilya Tikhonovsky
Modified: 2012-01-13 03:37 PST (History)
10 users (show)

See Also:

Patch (2.67 KB, patch)
2012-01-13 00:37 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-01-13 00:23:14 PST
_calculateFlags speed is about 10k edges per second.
It requires 150sec for the snapshot with 1.5m edges.
The root of problem is var node = list.shift();
It is not effective in term of memory and cpu.
In our case it can be replaced with pop().
Comment 1 Ilya Tikhonovsky 2012-01-13 00:37:16 PST
Created attachment 122389 [details]
Comment 2 Ilya Tikhonovsky 2012-01-13 03:36:53 PST
Comment on attachment 122389 [details]

Clearing flags on attachment: 122389

Committed r104916: <http://trac.webkit.org/changeset/104916>
Comment 3 Ilya Tikhonovsky 2012-01-13 03:37:01 PST
All reviewed patches have been landed.  Closing bug.