RESOLVED FIXED76243
[chromium] Reftests expected to be image mismatch still generate image mismatch when ran by NRWT --no-pixel-tests. 
https://bugs.webkit.org/show_bug.cgi?id=76243
Summary [chromium] Reftests expected to be image mismatch still generate image mismat...
Hao Zheng
Reported 2012-01-12 20:33:52 PST
For example, fast/harness/sample-fail-mismatch-reftest.html When ran by 'NRWT fast/harness/sample-fail-mismatch-reftest.html', all is fine: All 1 tests ran as expected. When ran by 'NRWT --no-pixel-tests fast/harness/sample-fail-mismatch-reftest.html', output: Regressions: Unexpected image mismatch : (1) fast/harness/sample-fail-mismatch-reftest.html = IMAGE In TestExpectations.matches_an_expected_result, it removes pixel expectation when pixel tests is disabled. if not pixel_tests_are_enabled: expected_results = remove_pixel_failures(expected_results) However, in test_failures.determine_result_type, reftest failure is treated as image failure. elif is_image_failure or is_reftest_failure: return test_expectations.IMAGE
Attachments
Proposed patch. (3.46 KB, patch)
2012-01-12 23:45 PST, Hao Zheng 		tony: review-
tony: commit-queue-
DetailsFormatted DiffDiff
Add test. (5.82 KB, patch)
2012-01-15 23:28 PST, Hao Zheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hao Zheng
Comment 1 2012-01-12 23:45:00 PST
Created attachment 122380 [details] Proposed patch.
Tony Chang
Comment 2 2012-01-13 10:14:00 PST
Comment on attachment 122380 [details] Proposed patch. This change looks correct, but can you add a unit test for the change to manager.py?
Hao Zheng
Comment 3 2012-01-15 23:28:47 PST
Created attachment 122596 [details] Add test.
WebKit Review Bot
Comment 4 2012-01-17 10:56:08 PST
Comment on attachment 122596 [details] Add test. Clearing flags on attachment: 122596 Committed r105169: <http://trac.webkit.org/changeset/105169>
WebKit Review Bot
Comment 5 2012-01-17 10:56:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.