Bug 76242 - [Mac][DRT] Should support --no-timeout
Summary: [Mac][DRT] Should support --no-timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 76156
  Show dependency treegraph
 
Reported: 2012-01-12 20:14 PST by Hajime Morrita
Modified: 2012-01-13 00:47 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.49 KB, patch)
2012-01-12 21:21 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (4.54 KB, patch)
2012-01-12 23:09 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (4.53 KB, patch)
2012-01-12 23:25 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-01-12 20:14:48 PST
This is a part of the effort to run Dromaeo on DRT.
Comment 1 Ryosuke Niwa 2012-01-12 20:19:43 PST
(In reply to comment #0)
> This is a part of the effort to run Dromaeo on DRT.

Alternatively, we can set a really high timeout (e.g. 30minutes) as done in perftestrunner:http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Comment 2 Hajime Morrita 2012-01-12 21:21:49 PST
Created attachment 122367 [details]
Patch
Comment 3 Hajime Morrita 2012-01-12 21:23:43 PST
> Alternatively, we can set a really high timeout (e.g. 30minutes) as done in perftestrunner:http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Yes. It will work in both way. We need some watchdog somehow and there is one in NRWT.
I just posted no-timeout version.
Comment 4 Hajime Morrita 2012-01-12 21:24:33 PST
> Yes. It will work in both way. We need some watchdog somehow and there is one in NRWT.
> I just posted no-timeout version.
This is also useful when you run DRT on the debugger.
Comment 5 Hajime Morrita 2012-01-12 22:12:57 PST
CC-ing folks who will know Mac DRT well...
Comment 6 Darin Adler 2012-01-12 22:28:34 PST
Comment on attachment 122367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122367&action=review

Looks OK.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1109
> +    ASSERT(timer);
> +    waitToDumpWatchdog = timer;

Should also ASSERT(!waitToDumpWatchdog)
Comment 7 Hajime Morrita 2012-01-12 23:04:58 PST
Hi Darin,
Thanks much for your quick response!

> > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1109
> > +    ASSERT(timer);
> > +    waitToDumpWatchdog = timer;
> 
> Should also ASSERT(!waitToDumpWatchdog)
Will fix before landing.
Comment 8 Hajime Morrita 2012-01-12 23:09:30 PST
Created attachment 122372 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-01-12 23:12:25 PST
Comment on attachment 122372 [details]
Patch for landing

Rejecting attachment 122372 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11115837
Comment 10 Hajime Morrita 2012-01-12 23:25:26 PST
Created attachment 122375 [details]
Patch for landing
Comment 11 WebKit Review Bot 2012-01-13 00:47:23 PST
Comment on attachment 122375 [details]
Patch for landing

Clearing flags on attachment: 122375

Committed r104902: <http://trac.webkit.org/changeset/104902>
Comment 12 WebKit Review Bot 2012-01-13 00:47:28 PST
All reviewed patches have been landed.  Closing bug.